Skip to content

Support popping arguments in built-in functions to avoid clone #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ngeor opened this issue Mar 2, 2021 · 0 comments
Open

Support popping arguments in built-in functions to avoid clone #56

ngeor opened this issue Mar 2, 2021 · 0 comments

Comments

@ngeor
Copy link
Owner

ngeor commented Mar 2, 2021 •
edited
Loading

For example, in ubound.rs:

let v: Variant = interpreter.context()[0].clone()

can be done by popping the variant instead.

Note that this is more difficult due to the way ByRef arguments are implemented (they're expected to be in-place, so popping causes issues).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngeor