-
Notifications
You must be signed in to change notification settings - Fork 825
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
domain.com >> www.domain.com #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Same questions on my side - plus: how would it be able to proxy additional domains (www.yourdomain1.com, yourdomain1.com, www.yourdomain2.com, mysub.yourdomain2.com...) to one http/80-container with an .env-configuration.file and get additional certificates for them, too? There are already answers, but it's not working on my docker host actually:
And can all subdomains be linked to the top domain with a wildcard (*.yourdomain1.com to cover www.yourdomain1.com, yourdomain1.com, mysub.yourdomain1.com ...)? |
@RonAlmog the answer is in the documentation #625 is an issue with pretty much zero info about what fails, how and why. This project should work for domains + subdomains, I personally have multiple domain + subdomain(s) setups in production and all are working fine. @Mesqualito please don't post the same question in multiple issues. If the method described in the docs isn't working you are either encountering a yet unidentified bug or misconfiguring something somewhere that prevents Let's Encrypt from issuing you a certificate. nginx-proxy/nginx-proxy#1369 is a pull request that hasn't been merged to
Nope, as wildcard certificates aren't supported. |
Thanks @buchdag , you're absolutely right. I followed the documentation (just comma separate the domain, subdomain) and it works! Both mywebsite.com and www.mywebsite.com are now working fine with ssl. |
@RonAlmog |
@RonAlmog the remaining question concerns nginx-proxy/nginx-proxy. nginx-proxy/docker-letsencrypt-nginx-proxy-companion only concern is the automatic issuance / naming of certificate and the reloadinf of the proxy / docker-gen so that the SSL configuration is enabled and active. Is it okay for you if I close this issue ? |
@shiz0 , thanks for your suggestion, but since those tmpl files are foreign language for me, i need clear directions what to do. |
The redirect issue is actually not a problem of this project (the companion), but of nginx-proxy itself. |
@shiz0 Using your file as template for my docker-gen installation, I can confirm it works perfectly. In the end, my environment variables looked like this, and all variants of website.test, othersite.com redirected to https://website.test. environment:
- VIRTUAL_HOST=website.test
- VIRTUAL_HOST_ALIAS=othersite.com,www.othersite.com,www.website.test
- LETSENCRYPT_HOST=website.test,othersite.com,www.othersite.com,www.website.test |
@shiz0 did you pr your |
As of now I did not, as the main work for that feature was done by @dannycarrera in nginx-proxy/nginx-proxy#1369 and I just did some fixes to make it work properly as intended. So it felt wrong to merge his work and my changes and start a new PR myself, but instead asked him to update his PR with my fixes. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
As some people said, this works great, but only for subdomains. for my main domain it fails.
Regardless, I want both mydomain.com and www.mydomain.com to go to the same place, and not be separate, for seo reasons.
Whats the best way to achieve this?
I'm using the 3 container method, so if i copy the example from the wiki:
And the 'subdomain' in my case is www, Then my question is: how do i add the top level domain (yourdomain.tld) and how do i cause all traffic from it to be redirected to www.yourdomain.tld ? (or vice versa, would be good as well)
Thanks!
The text was updated successfully, but these errors were encountered: