getProxy() doesn't handle proxies properly

[ghost]

Forum thread.

Problematic line.

return newProxy($parsed, auth)

$parsed will always return with something like:

(scheme: "http", username: "", password: "", hostname: "10.10.10.10", port: "8080", path: "", query: "", anchor: "", opaque: false)

instead of a real URL. parseUri is working with real URLs.

Choosenim is also affected..

@dom96 lets discuss the solution. I could create a MR with return newProxy(url, auth) where url could be prefixed with http:// if the scheme was empty in the condition before it.

[ghost]

We could also overload newProxy() to accept an Uri. This would also make it perform better.

[dom96]

$parsed will always return with something like: [...]

How? $ for Uri is defined in the uri module: https://nim-lang.org/docs/uri.html#%24%2CUri

[ghost]

Oh, I see! So Nim's $ strikes again(me thinking it's a virtual method)! Probably importing the whole module needs to be a Nim "good practice" because in other languages it's the opposite.

[ghost]

In the forum thread I had from uri import parseUri.

[dom96]

oh damn. I can see the confusion, and indeed, it's subtle. Not sure what we could really do here to prevent this mistake.

[ghost]

The ones preventing this would either impact performance(vtables everywhere) or make it really uncomfortable(disabling the default $ for types in general - would need to import it). This issue affects pretty much every non-OO language so it might be a good idea to make it the linters' job.

[Araq]

@trialism We have some ideas about how to prevent this without a vtable overhead but this is not the place to discuss it, see nim-lang/RFCs#139