Skip to content

Transfer MattIPv4/discord-status-worker to nodejs org #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MattIPv4 opened this issue Mar 24, 2025 · 19 comments
Closed

Transfer MattIPv4/discord-status-worker to nodejs org #960

MattIPv4 opened this issue Mar 24, 2025 · 19 comments

Comments

@MattIPv4
Copy link
Member

MattIPv4 commented Mar 24, 2025

👋 I'd like to transfer https://github.com/MattIPv4/discord-status-worker into the nodejs org, please. It is a small Cloudflare Worker deployed to the nodejs.org account, providing a feed of the Node.js status page to the Node.js Discord server.

cc @nodejs/web-infra

@AugustinMauroy
Copy link
Member

is it already deployed to nodejs CF account ?

@MattIPv4
Copy link
Member Author

Yes, this is already deployed (the repo has an Action setup to deploy main), and is running in a channel in the Discord (albeit private at present).

@Trott
Copy link
Member

Trott commented Mar 27, 2025

@nodejs/tsc

@ovflowd
Copy link
Member

ovflowd commented Mar 30, 2025

is it already deployed to nodejs CF account ?

No. It is deployed to another account, also under Node.js, but it is not the build account. Why are you interested on knowing that? 👀

@AugustinMauroy
Copy link
Member

why are you interested on knowing that? 👀

It surprised me that a repo is deployed when it's not in the org node can be published with the org account.

@ovflowd
Copy link
Member

ovflowd commented Mar 30, 2025

why are you interested on knowing that? 👀

It surprised me that a repo is deployed when it's not in the org node can be published with the org account.

I’m not sure why that would make a difference. The question is valid, but it depends on how these things are sourced, not on Cloudflare’s side. If the repository wasn’t ready for transfer, Matt and I wouldn’t have opened this request.

@ovflowd
Copy link
Member

ovflowd commented Apr 7, 2025

cc @nodejs/tsc can we please do the transfer? 🙏

@legendecas
Copy link
Member

+1

@ovflowd
Copy link
Member

ovflowd commented Apr 14, 2025

@nodejs/tsc another bump :)

@MattIPv4
Copy link
Member Author

👋 Hey folks, just wanted to check in on this and if there's anything I need to do to move this forward, as it's been open for close to a month now?

@nschonni
Copy link
Member

As this is a fork + patch/config of https://github.com/WalshyDev/cf-status-worker, could this also be achieved by adding scripts to the build repo instead?

@MattIPv4
Copy link
Member Author

MattIPv4 commented Apr 21, 2025

Yes, it probably could, though I'm hesitant to pollute the build repo with entirely new build scripts that'd be interfacing with Cloudflare workers, and something that'd be owned by web-infra rather than build?

nodejs/build#2299 (comment) also comes to mind when I previously tried to add net-new items to build and got nowhere.

@nschonni
Copy link
Member

Other idea would be to add a manual GitHub action in the node.js repo to clone + configure + push the original project

@MattIPv4
Copy link
Member Author

MattIPv4 commented Apr 21, 2025

Sure, you could have a manual GitHub Action, but it'd still need to store the patches + SHA somewhere, so it might as well be an automated one that does it based on pushes to said patches/SHA -- which is what the current repo I'm asking to transfer is, a home for said patches + SHA, and automated GitHub Actions to publish the worker when those are pushed.

Which repo are you referring to though, I'm not sure I see it fitting into build or nodejs.org?

@flakey5
Copy link
Member

flakey5 commented Apr 21, 2025

Yes, it probably could, though I'm hesitant to pollute the build repo with entirely new build scripts that'd be interfacing with Cloudflare workers, and something that'd be owned by web-infra rather than build?

+1

@aduh95
Copy link
Contributor

aduh95 commented Apr 22, 2025

Here's what our policy says on repo transfer request approvals:

Provided there are no objections from any TSC members raised in
the issue, such requests are approved automatically after 72 hours. If any
objection is made, the request shall not be completed without a vote from
the TSC to dismiss the objection.

The remaining action is to transfer the repo, which can only be done by the current repo owner, not the TSC.

@MattIPv4
Copy link
Member Author

Ah wonderful, I wasn't aware such requests had auto-approval. Will start the transfer.

@MattIPv4
Copy link
Member Author

Transferred over: https://github.com/nodejs/discord-status-worker. Would someone with the right powers grant web-infra permissions to the repo, either maintain or admin?

@aduh95
Copy link
Contributor

aduh95 commented Apr 22, 2025

I've added @nodejs/web-infra Maintain role, and remove the existing Write roles.

@aduh95 aduh95 closed this as completed Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants