Skip to content

Commit 84063a7

Browse files
committed
src: do not include internals from node_buffer.h
`node_buffer.h` is a public header, so it should not be using the `node_internals.h` internal header. Ref: 290315a Fixes: #15552 PR-URL: #15554 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent 6983157 commit 84063a7

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

src/node_buffer.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
#ifndef SRC_NODE_BUFFER_H_
2323
#define SRC_NODE_BUFFER_H_
2424

25-
#include "node_internals.h"
25+
#include "node.h"
26+
#include "v8.h"
2627

2728
namespace node {
2829

src/node_serdes.cc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
1-
#include "node.h"
1+
#include "node_internals.h"
22
#include "node_buffer.h"
33
#include "base-object.h"
44
#include "base-object-inl.h"
5-
#include "env.h"
6-
#include "env-inl.h"
7-
#include "v8.h"
85

96
namespace node {
107

src/spawn_sync.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
2626

27-
#include "node.h"
27+
#include "node_internals.h"
2828
#include "node_buffer.h"
2929

3030
namespace node {

src/string_bytes.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@
2222
#include "string_bytes.h"
2323

2424
#include "base64.h"
25-
#include "node.h"
25+
#include "node_internals.h"
2626
#include "node_buffer.h"
27-
#include "v8.h"
2827

2928
#include <limits.h>
3029
#include <string.h> // memcpy

0 commit comments

Comments
 (0)