Skip to content

Commit 5bc2d2d

Browse files
authored
Drop keyframesName function, exposing KeyframesName constructor instead. (#34)
* Drop keyframesName function, exposing KeyframesName constructor instead. * Add CHANGELOG entry regarding KeyframesName.
1 parent 1097b36 commit 5bc2d2d

File tree

6 files changed

+24
-19
lines changed

6 files changed

+24
-19
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Notable changes are documented in this file. The format is based on [Keep a Chan
66

77
Breaking changes:
88
- _For pseudo-elements only_, the `&:` operator has bee replaced by `&::`. Pseudo-classes continue to work with the `&:` operator. (nsaunders/purescript-tecton#33)
9+
- The `keyframesName` function has been dropped. Just use the `KeyframesName` constructor instead. (nsaunders/purescript-tecton#34)
910

1011
For example:
1112

examples/ZenGarments.purs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ import Data.Tuple.Nested ((/\))
77
import Effect (Effect)
88
import Effect.Console (log)
99
import Tecton
10-
( a
10+
( KeyframesName(..)
11+
, a
1112
, abbr
1213
, absolute
1314
, acronym
@@ -77,7 +78,6 @@ import Tecton
7778
, input
7879
, italic
7980
, keyframes
80-
, keyframesName
8181
, label
8282
, left
8383
, letterSpacing
@@ -892,7 +892,7 @@ main = log $ renderSheet pretty do
892892

893893
-- Animations
894894

895-
let fadey = keyframesName "FADEY"
895+
let fadey = KeyframesName "FADEY"
896896

897897
keyframes fadey ? do
898898
pct 0 ? Rule.do

examples/type-errors/KeyframesNonAnimatableProperty.purs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,21 @@ module TypeError.KeyframesNonAnimatableProperty where
1313

1414
import Prelude
1515

16-
import Tecton (CSS, content, keyframes, keyframesName, nil, pct, (:=), (?))
16+
import Tecton
17+
( CSS
18+
, KeyframesName(..)
19+
, content
20+
, keyframes
21+
, nil
22+
, pct
23+
, (:=)
24+
, (?)
25+
)
1726
import Tecton.Rule as Rule
1827

1928
css :: CSS
2029
css = do
21-
keyframes (keyframesName "foo") ? do
30+
keyframes (KeyframesName "foo") ? do
2231
pct 0 ? Rule.do
2332
content := ""
2433
pct 100 ? Rule.do

src/Tecton.purs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import Tecton.Internal
44
( CSS
55
, CustomAttribute
66
, Declarations
7-
, KeyframesName
7+
, KeyframesName(..)
88
, a
99
, abbr
1010
, absolute
@@ -306,7 +306,6 @@ import Tecton.Internal
306306
, katakanaIroha
307307
, keepAll
308308
, keyframes
309-
, keyframesName
310309
, khmer
311310
, kind
312311
, label

src/Tecton/Internal.purs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ module Tecton.Internal
4747
, Inextensible
4848
, KeyframeBlock
4949
, Keyframes
50-
, KeyframesName
50+
, KeyframesName(..)
5151
, Length
5252
, LengthPercentage
5353
, LineName
@@ -554,7 +554,6 @@ module Tecton.Internal
554554
, katakanaIroha
555555
, keepAll
556556
, keyframes
557-
, keyframesName
558557
, khmer
559558
, kind
560559
, label
@@ -1821,9 +1820,6 @@ newtype KeyframesName = KeyframesName String
18211820

18221821
derive newtype instance ToVal KeyframesName
18231822

1824-
keyframesName :: String -> KeyframesName
1825-
keyframesName = KeyframesName
1826-
18271823
newtype Keyframes = Keyframes KeyframesName
18281824

18291825
keyframes :: KeyframesName -> Keyframes

test/AnimationsSpec.purs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import Prelude
66

77
import Data.Tuple.Nested ((/\))
88
import Tecton
9-
( all
9+
( KeyframesName(..)
10+
, all
1011
, alternate
1112
, alternateReverse
1213
, animationDelay
@@ -34,7 +35,6 @@ import Tecton
3435
, jumpNone
3536
, jumpStart
3637
, keyframes
37-
, keyframesName
3838
, linear
3939
, media
4040
, ms
@@ -72,19 +72,19 @@ spec =
7272

7373
"@keyframes foo{0%{width:0}100%{width:500px}}"
7474
`isRenderedFrom` do
75-
keyframes (keyframesName "foo") ? do
75+
keyframes (KeyframesName "foo") ? do
7676
pct 0 ? width := nil
7777
pct 100 ? width := px 500
7878

7979
"@media all{@keyframes foo{0%,100%{width:0}}}"
8080
`isRenderedFrom` do
8181
media all {} ? do
82-
keyframes (keyframesName "foo") ? do
82+
keyframes (KeyframesName "foo") ? do
8383
pct 0 /\ pct 100 ? width := nil
8484

8585
"@keyframes foo{0%{width:75%}20%{width:80%}50%{width:100%}}"
8686
`isRenderedFrom` do
87-
keyframes (keyframesName "foo") ? do
87+
keyframes (KeyframesName "foo") ? do
8888
pct 0 ? width := pct 75
8989
pct 10 @+@ pct 5 @* 2 ? width := pct 80
9090
pct 100 @/ 2 ? width := pct 100
@@ -101,11 +101,11 @@ spec =
101101

102102
"animation-name:none" `isRenderedFrom` (animationName := none)
103103

104-
"animation-name:xx" `isRenderedFrom` (animationName := keyframesName "xx")
104+
"animation-name:xx" `isRenderedFrom` (animationName := KeyframesName "xx")
105105

106106
"animation-name:foo,none,bar"
107107
`isRenderedFrom`
108-
(animationName := keyframesName "foo" /\ none /\ keyframesName "bar")
108+
(animationName := KeyframesName "foo" /\ none /\ KeyframesName "bar")
109109

110110
describe "animation-duration property" do
111111

0 commit comments

Comments
 (0)