fix the android mute setter

Author: bradmartin

.gitignore

@@ -5,6 +5,7 @@
 !references.d.ts
 !index.d.ts
 !manual_typings/base.d.ts
+demo/e2e/
 demo/lib
 demo/app/*.js
 demo/*.d.ts

README.md

@@ -39,13 +39,13 @@
 
 ### Android Native Classes
 
-* [Player - android.media.MediaPlayer](http://developer.android.com/reference/android/media/MediaPlayer.html)
-* [Recorder - android.media.MediaRecorder](http://developer.android.com/reference/android/media/MediaRecorder.html)
+- [Player - android.media.MediaPlayer](http://developer.android.com/reference/android/media/MediaPlayer.html)
+- [Recorder - android.media.MediaRecorder](http://developer.android.com/reference/android/media/MediaRecorder.html)
 
 ### iOS Native Classes
 
-* [Player - AVAudioPlayer](https://developer.apple.com/library/ios/documentation/AVFoundation/Reference/AVAudioPlayerClassReference/)
-* [Recorder - AVAudioRecorder](https://developer.apple.com/library/ios/documentation/AVFoundation/Reference/AVAudioRecorder_ClassReference/)
+- [Player - AVAudioPlayer](https://developer.apple.com/library/ios/documentation/AVFoundation/Reference/AVAudioPlayerClassReference/)
+- [Recorder - AVAudioRecorder](https://developer.apple.com/library/ios/documentation/AVFoundation/Reference/AVAudioRecorder_ClassReference/)
 
 Note: You will need to grant permissions on iOS to allow the device to access the microphone if you are using the recording function. If you don't, your app may crash on device and/or your app might be rejected during Apple's review routine. To do this, add this key to your `app/App_Resources/iOS/Info.plist` file:
 
@@ -195,3 +195,9 @@ player
 ### License
 
 [MIT](/LICENSE)
+
+### Demo App
+
+- fork/clone the repository
+- cd into the `src` directory
+- execute `npm run demo.android` or `npm run demo.ios` (scripts are located in the `scripts` of the package.json in the `src` directory if you are curious)

demo/app/main-page.xml

@@ -23,7 +23,7 @@
       <TabViewItem title="Player">
         <TabViewItem.view>
           <ScrollView>
-            <GridLayout rows="auto, auto, auto, auto, auto, auto, auto, auto, auto, auto, auto" columns="*, *, *" class="p-10">
+            <GridLayout rows="auto, auto, auto, auto, auto, auto, auto, auto, auto, auto, auto, auto" columns="*, *, *" class="p-10">
               <label row="0" colSpan="3" class="center text-primary h3" text="Welcome To Fight Club!" textWrap="true" />
               <button row="1" colSpan="3" class="btn btn-primary" text="Play Remote Audio" tap="{{ playRemoteFile }}" />
               <label row="2" colSpan="3" text="Note: Remote files can have a lag before playing due to processing and network speeds." class="h4" textWrap="true" />
@@ -42,6 +42,8 @@
               <Label row="10" col="0" text="Volume Slider: " textWrap="true" class="m-t-20" />
               <Slider row="10" col="1" colSpan="2" id="volumeSlider" minValue="0" maxValue="100" value="100" class="m-t-20" />
               <Label text="{{ 'Current Volume for Player ' + currentVolume }}" textWrap="true" />
+              <Button row="11" col="0" text="Mute" class="btn btn-primary" tap="{{ muteTap }}" />
+              <Button row="11" col="1" text="Unmute" class="btn btn-primary" tap="{{ unmuteTap }}" />
             </GridLayout>
           </ScrollView>
         </TabViewItem.view>

demo/app/main-view-model.ts

@@ -285,6 +285,14 @@ export class AudioDemo extends Observable {
     this._player.play();
   }
 
+  public muteTap() {
+    this._player.volume = 0;
+  }
+
+  public unmuteTap() {
+    this._player.volume = 1;
+  }
+
   public playSpeed1() {
     this._player.changePlayerSpeed(1);
   }

demo/package.json

@@ -3,6 +3,9 @@
     "id": "org.nativescript.audio",
     "tns-ios": {
       "version": "4.1.0"
+    },
+    "tns-android": {
+      "version": "4.1.3"
     }
   },
   "dependencies": {

src/android/player.ts

@@ -43,7 +43,7 @@ export class TNSPlayer implements TNSPlayerI {
   }
 
   set volume(value: number) {
-    if (this._player && value) {
+    if (this._player && value >= 0) {
       this._player.setVolume(value, value);
     }
   }
@@ -365,7 +365,7 @@ export class TNSPlayer implements TNSPlayerI {
   }
 
   private _getAndroidContext() {
-    const ctx = app.android.context
+    const ctx = app.android.context;
     if (ctx === null) {
       setTimeout(() => {
         this._getAndroidContext();

src/package.json

@@ -17,7 +17,7 @@
     "demo.reset": "cd ../demo && rimraf platforms",
     "demo.ios": "npm run preparedemo && cd ../demo && tns run ios --syncAllFiles",
     "demo.ios.device": "npm run preparedemo && cd ../demo && tns platform remove ios && tns run ios",
-    "demo.android": "npm i && npm run tsc && cd ../demo && tns run android --syncAllFiles",
+    "demo.android": "npm run preparedemo && cd ../demo && tns run android --syncAllFiles",
     "test": "npm run tslint && npm run tslint.demo && cd ../demo && tns build ios && tns build android",
     "test.ios": "cd ../demo && tns platform remove ios && tns test ios --emulator",
     "test.ios.device": "cd ../demo && tns platform remove ios && tns test ios",

src/tsconfig.json

@@ -1,29 +1,22 @@
 {
   "compilerOptions": {
-    "target": "es5",
-    "module": "commonjs",
-    "declaration": false,
+    "noEmitOnError": false,
+    "noEmitHelpers": true,
+    "sourceMap": false,
     "removeComments": true,
+    "declaration": false,
+    "experimentalDecorators": true,
     "noLib": false,
     "emitDecoratorMetadata": true,
-    "experimentalDecorators": true,
+    "target": "es5",
+    "module": "commonjs",
     "lib": ["es6", "dom"],
+    "skipLibCheck": true,
+    "rootDir": ".",
     "baseUrl": ".",
     "paths": {
       "*": ["./node_modules/tns-core-modules/*", "./node_modules/*"]
-    },
-    "skipLibCheck": true,
-    "sourceMap": true,
-    "pretty": true,
-    "allowUnreachableCode": false,
-    "allowUnusedLabels": false,
-    "noEmitHelpers": true,
-    "noEmitOnError": false,
-    "noImplicitAny": false,
-    "noImplicitReturns": true,
-    "noImplicitUseStrict": false,
-    "noFallthroughCasesInSwitch": true
+    }
   },
-  "exclude": ["node_modules"],
-  "compileOnSave": false
+  "exclude": ["node_modules"]
 }