type `ColorModeInstance.value` as readonly #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

OrbisK opened this issue Apr 8, 2025 · 0 comments

Labels

OrbisK commented Apr 8, 2025

color-mode/src/runtime/types.ts

Line 4 in df97711

value: string

Is your feature request related to a problem? Please describe.

colorMode.value should be readonly at least as type.

Additional context

I always fall for writing to value instead of preference. Maybe with readonly type we can make it more obvious not to write to value.

OrbisK added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment