Buffer not replaced when using vinegar-style API

[steliyan]

Until now I've been using open_replacing_current_buffer which seems to be a legacy API (ref: #1918). It was working as expected for long time, but recently it broke. More specifically, what is not working is selecting a file nvim-tree is opened.

I've tried the new one (api.tree.toggle), but still doesn't fit my use case.

I feel this is kinda related to this: #1829, but I am not 100% sure.

Here are 2 screen captures which would be pretty self-explanatory. Note the example uses pretty simple file structure and used for a simple show-case, the real world example would have a lot of directory nesting.

I would like to have my nvim-tree buffer replaced when I choose a file outside nvim-tree. For the purpose of the video, I use Telescope, but similar behavior is observed if :edit a.txt command is used.

Am I missing something or should I file a bug?

Reproduction

require'nvim-tree'.open_replacing_current_buffer()

Screen.Recording.2023-05-12.at.10.44.59.mov

Here the buffer just flashes.

require'nvim-tree.api'.tree.toggle({current_window=true})

Screen.Recording.2023-05-12.at.10.45.42.mov

Here a new buffer is created.

[alex-courtis]

I've not reviewed your entire post, however I think Vinegar Style should meet your needs.

[steliyan]

I am using in Vinegar Style, my problem is I can't properly open a file outside nvim-tree when nvim-tree is the active buffer. If you check the videos, you'll see the problem. :)

[alex-courtis]

I see.

What happens when you use api.node.open.replace_tree_buffer() as per the wiki? open_replacing_current_buffer is not API.

Please post a bug report with a "Clean Room" Replication so that we may replicate and fix this.

[steliyan]

If I use replace_tree_buffer (or the default <C-e> mapping), the file is edited in-place as expected.

I checked the code and I see that the window in the current tab page is closed and the selected file opened.

But if I do :e some_file_name then this is opened in a new window which was not the behavior before.

[alex-courtis]

If I use replace_tree_buffer (or the default <C-e> mapping), the file is edited in-place as expected.

Good to hear that is working.

But if I do :e some_file_name then this is opened in a new window which was not the behavior before.

That's hardcoded nvim-tree behaviour.

Please experiment with removing it, by commenting out the autocommand:

nvim-tree.lua/lua/nvim-tree.lua

Line 194 in 498e879

-- prevent new opened file from opening in the same window as nvim-tree

[alex-courtis]

Raised #2218

Pull requests are most gratefully appreciated!