Please fix the setup script for macOS

[anton-bedrock]

On macOS there setup script mentioned bash completions, but it should be zsh completions instead. An easy fix, but it will save hours for many macOS users. Please fix it.

After running the following command to install NVM.

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash

my .zshrc file had the following added.

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

After restarting the terminal, it appeared.

zsh compinit: insecure directories, run compaudit for list.
Ignore insecure directories and continue [y] or abort compinit [n]?

After changing bash_completion to zsh_completion, the error disappeared.

Originally posted by @amlzq in #2361

[ljharb]

Not all Mac OS users use zsh, so it definitely shouldn’t do it by platform.

[anton-bedrock]

@ljharb said:

Not all Mac OS users use zsh, so it definitely shouldn’t do it by platform.

I think last 2-3 years macOS ships with zsh. So you always can check if zsh is available and use one output, with a fallback to bash. Seems an easy check

[ljharb]

Yes, that's true, but if you've continuously migrated your Mac environment from prior to that, then you'll stay on bash, as I have.

zsh is always available now, that can't be used to make a choice.

I have a .bashrc, .bash_profile, and .zshrc present, but bash is my default. What logic would you suggest that can select "bash" for me but "zsh" for you?