feat: change rules for the styleguide of team

Author: koppthe

rules/best-practices.js

@@ -25,7 +25,7 @@ module.exports = {
     'curly': ['error', 'multi-line'],
 
     // require default case in switch statements
-    'default-case': 'off',
+    'default-case': 'error',
 
     // enforce newline before and after dot
     'dot-location': ['error', 'property'],
@@ -86,7 +86,7 @@ module.exports = {
     'no-fallthrough': 'error',
 
     // disallow floating decimals
-    'no-floating-decimal': 'error',
+    'no-floating-decimal': 'off',
 
     // disallow assignment to native objects or read-only global variables
     'no-global-assign': 'error',
@@ -125,7 +125,7 @@ module.exports = {
     'no-multi-str': 'error',
 
     // disallow new for side effects
-    'no-new': 'error',
+    'no-new': 'off',
 
     // disallow function constructor
     'no-new-func': 'error',
@@ -234,6 +234,6 @@ module.exports = {
     'wrap-iife': ['error', 'any', { functionPrototypeMethods: true }],
 
     // require or disallow Yoda conditions
-    'yoda': ['error', 'never']
+    'yoda': 'off'
   }
 }

rules/es6.js

@@ -87,7 +87,7 @@ module.exports = {
     'prefer-rest-params': 'error',
 
     // suggest using the spread operator instead of .apply()
-    'prefer-spread': 'warn',
+    'prefer-spread': 'off',
 
     // suggest using template literals instead of string concatenation
     'prefer-template': 'error',

rules/style.js

@@ -16,7 +16,8 @@ module.exports = {
     'block-spacing': 'error',
 
     // require brace style
-    'brace-style': ['error', '1tbs', { allowSingleLine: true }],
+    // 'brace-style': ['error', '1tbs', { allowSingleLine: true }],
+    'brace-style': 'off',
 
     // require camelcase
     'camelcase': ['error', { properties: 'never' }],
@@ -151,7 +152,7 @@ module.exports = {
     'no-inline-comments': 'off',
 
     // disallow if statements as the only statement in else blocks
-    'no-lonely-if': 'error',
+    'no-lonely-if': 'off',
 
     // Disallow mixes of different operators
     'no-mixed-operators': ['error', {
@@ -178,7 +179,7 @@ module.exports = {
     'no-negated-condition': 'off',
 
     // disallow nested ternary expressions
-    'no-nested-ternary': 'error',
+    'no-nested-ternary': 'warn',
 
     // disallow Object constructors
     'no-new-object': 'error',
@@ -256,7 +257,8 @@ module.exports = {
     'require-jsdoc': 'off',
 
     // require or disallow semicolons instead of ASI
-    'semi': ['error', 'never'],
+    // 'semi': ['error', 'never'],
+    'semi': 'off',
 
     // enforce spacing before and after semicolons
     'semi-spacing': ['error', { before: false, after: true }],

test/validate-base.js

@@ -1,17 +1,11 @@
 import index from '../'
-import legacy from '../legacy'
 import test from 'ava'
 
 test('test basic properties of eslint config - index.js', t => {
   t.truthy(isArray(index.extends))
   t.truthy(isObject(index.parserOptions))
 })
 
-test('test basic properties of eslint config - legacy.js', t => {
-  t.truthy(isArray(legacy.extends))
-  t.truthy(isObject(legacy.env))
-})
-
 function isObject (obj) {
   return typeof obj === 'object' && obj !== null
 }

test/validate-config.js

@@ -14,7 +14,6 @@ fs.readdirSync(path.join(__dirname, '../rules')).forEach(name => {
 // the repo file to test lint
 const repoFiles = [
   'index.js',
-  'legacy.js',
   'test/*.js'
 ]