Skip to content

Record field and variant case rendering breaks cut and paste #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbuenzli opened this issue Feb 11, 2019 · 7 comments · Fixed by #615
Closed

Record field and variant case rendering breaks cut and paste #296

dbuenzli opened this issue Feb 11, 2019 · 7 comments · Fixed by #615
Labels
bug Something isn't working output

Comments

@dbuenzli
Copy link
Contributor

Please don't do this. Either do it like ocamldoc did by putting the field doc string in a regular ocaml comment or find a markup strategy that allows to select only the type definition.

For reference:

@rizo
Copy link
Collaborator

rizo commented Feb 11, 2019

Either do it like ocamldoc did by putting the field doc string in a regular ocaml comment or find a markup strategy that allows to select only the type definition.

Maybe both?

@dbuenzli
Copy link
Contributor Author

Maybe both?

I mean if you manage to select only the type definition you could decently argue that the comment delimiters are going to look like noise since you can distinguish them via typography.

@rizo
Copy link
Collaborator

rizo commented Feb 11, 2019

Looking into it. Seems like disabling selection on comments is quite easy and would work (I don't think that's a good idea though), but changing the direction to select vertically in a table is not.

Might be better to just add delimiters.

@dbuenzli
Copy link
Contributor Author

Looking into it. Seems like disabling selection on comments is quite easy and would work (I don't that's a good idea though), but changing the direction to select vertically in a table is not.

To be honest I don't have a strong opinion on that. But OTOH when you cut and paste say a value signature you don't get the doc string with it.

@trefis
Copy link
Contributor

trefis commented Feb 12, 2019

but changing the direction to select vertically in a table is not.

IIRC the plan is to stop using a table for these anyway.

@dbuenzli
Copy link
Contributor Author

Reopening. #615 didn't fix that in the end.

@dbuenzli
Copy link
Contributor Author

But #626 did. Thanks @Drup.

Currently the c&p when comments are oneliners is not that great because of the p, but that should improve if the scheme in #614 is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working output
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants