items are also generator

Author: michgur

package.json

@@ -1,7 +1,7 @@
 {
     "name": "oneai",
     "main": "lib/src/index.js",
-    "version": "0.3.6",
+    "version": "0.3.7",
     "repository": "github:power-of-language/oneai-sdk-node",
     "scripts": {
         "build": "tsc",

src/clustering.ts

@@ -134,18 +134,18 @@ export namespace ClusteringClient {
       this.metadata = metadata;
     }
 
-    async getItems(
+    async* getItems(
       params?: {
         itemMetadata?: string,
       },
-    ): Promise<Item[]> {
+    ): AsyncGenerator<Item, void, undefined> {
       const urlParams = new URLSearchParams();
       if (params?.itemMetadata !== undefined) urlParams.set('item-metadata', params?.itemMetadata!);
       const { data } = await this.cluster.collection.client.GET(
         `${this.cluster.collection.name}/phrases/${this.id}/items?${urlParams}`,
         this.cluster.collection.apiKey,
       );
-      return data ? data.map((item: any) => Item.fromJson(this, item)) : [];
+      yield* data ? data.map((item: any) => Item.fromJson(this, item)) : [];
     }
 
     static fromJson(cluster: Cluster, phrase: any): Phrase {

test/clustering.js

@@ -42,12 +42,8 @@ describe('Clustering', () => {
         console.log(`\t${cluster.text}`);
         const phrase = (await cluster.getPhrases().next()).value;
         console.log(`\t\t${phrase.text}`);
-        try {
-          const item = (await phrase.getItems())[0];
+        for await (const item of phrase.getItems()) {
           console.log(`\t\t\t${item.text}`);
-        } catch (e) {
-          console.log(e);
-          throw e;
         }
       }
     }