Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v4.0.1) Use js Map in ODManager instead of Array for data object #126

Closed
DJj123dj opened this issue Jan 21, 2025 · 0 comments
Closed

(v4.0.1) Use js Map in ODManager instead of Array for data object #126

DJj123dj opened this issue Jan 21, 2025 · 0 comments
Assignees
@DJj123dj
Labels
Minor Feature A small feature request which affects a smaller portion of the bot.

Comments

@DJj123dj
Copy link
Member

Feature

Use the default built-in Map feature from javascript to store data in the ODManager instead of the default Array.

  • This is better for performance
  • Has a simpler implementation
  • Is better for future compatibility & feature additions
@DJj123dj DJj123dj self-assigned this Jan 21, 2025
@DJj123dj DJj123dj added the Minor Feature A small feature request which affects a smaller portion of the bot. label Jan 21, 2025
@DJj123dj DJj123dj removed their assignment Jan 21, 2025
@DJj123dj DJj123dj pinned this issue Mar 25, 2025
@DJj123dj DJj123dj self-assigned this Mar 26, 2025
@DJj123dj DJj123dj changed the title Use js Map in ODManager instead of Array for data object (v4.0.1) Use js Map in ODManager instead of Array for data object Mar 26, 2025
DJj123dj added a commit that referenced this issue Mar 29, 2025
@DJj123dj
#126 : ODManagers now use Maps instead of Arrays
51bfb1a 
This results in a minor speed increase within large managers (e.g. builders, tickets, blacklist, ...)
@DJj123dj DJj123dj mentioned this issue Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJj123dj DJj123dj

Labels
Minor Feature A small feature request which affects a smaller portion of the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DJj123dj