Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the span name format for gin-gonic/gin to the latest semconv #7088

Open
minimAluminiumalism opened this issue Apr 1, 2025 · 2 comments · May be fixed by #6381
Open

Update the span name format for gin-gonic/gin to the latest semconv #7088

minimAluminiumalism opened this issue Apr 1, 2025 · 2 comments · May be fixed by #6381
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgin

Comments

@minimAluminiumalism
Copy link

Problem Statement

According to the latest semconv of http:

HTTP span names SHOULD be {method} {target} if there is a (low-cardinality) target available. If there is no (low-cardinality) {target} available, HTTP span names SHOULD be {method}.

Currently the span name of gin-gonic/gin instrumetation is still http.route(or URL path) like following(instrumentation/github.com/gin-gonic/gin/otelgin/example):

Image

Maybe we should update the span name format?

If needed I can submit a PR to fix that.

Proposed Solution

Add request method to span name.

Alternatives

A clear and concise description of any alternative solutions or features you've considered.

Prior Art

A clear and concise list of any similar and existing solutions from other projects that provide context to possible solutions.

Additional Context

Add any other context or screenshots about the feature request here.

@minimAluminiumalism minimAluminiumalism added area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgin labels Apr 1, 2025
@MrAlias
Copy link
Contributor

MrAlias commented Apr 3, 2025

cc @akats7

@akats7
Copy link
Contributor

akats7 commented Apr 8, 2025

Hi @minimAluminiumalism, thanks for this issue. This seems tied to this PR #6381 that should update the default span name format from just using the full path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgin
Projects
None yet
3 participants