Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove harness.go from internal/internaltest #6522

Open
MrAlias opened this issue Mar 26, 2025 · 1 comment · May be fixed by #6599
Open

Remove harness.go from internal/internaltest #6522

MrAlias opened this issue Mar 26, 2025 · 1 comment · May be fixed by #6599
Assignees
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 26, 2025

This file contains unused types. It is not needed.

This is a generated file, so internal/gen.go will need to be updated.

This file contains the internaltest package documentation. The harness.go.tmpl file needs to be updated. The package documentation from that file needs to be moved to a dedicated doc.go.tmpl file. That new template needs to then be generated in internal/internaltest and any other spot in the project where internaltest is used:

  • sdk/internal/internaltest
  • exporters/zipkin/internal/internaltest
@MrAlias MrAlias added the good first issue Good for newcomers label Mar 26, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 26, 2025
@MrAlias MrAlias added the contribfest Issue good for KubeCon contribfest label Apr 1, 2025
@stooj
Copy link

stooj commented Apr 2, 2025

I'm working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants