Skip to content

[operator] Make TLS secret Helm hooks optional #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvoravong opened this issue Mar 14, 2025 · 1 comment
Open

[operator] Make TLS secret Helm hooks optional #1569

jvoravong opened this issue Mar 14, 2025 · 1 comment
Labels
chart:operator Issue related to opentelemetry-operator helm chart

Comments

@jvoravong
Copy link
Contributor

Description:
Currently, Helm always uses pre-install and pre-upgrade hooks to deploy user-supplied or Helm-generated certificates (reference). However, this is not always desirable. I propose making these hooks optional via values.yaml overrides, leveraging the existing admissionWebhooks.secretAnnotations value field. Created a PR implements with this change and includes an UPGRADING.md entry.

Why:

  • Helm hooks are not universally supported across all Kubernetes deployment methods, such as the
    AWS EKS add-on method.
  • The "helm.sh/hook-delete-policy": "before-hook-creation"annotation can prevent the TLS secret from
    being deleted when uninstalling the chart or migrating to cert-manager, potentially causing deployment
    errors such as "secret already exists and is managed by another chart."

Impact:
This change introduces optional Helm hooks while keeping them enabled by default, ensuring backwards compatibility for most users. However, there is a breaking change for users who have already customized admissionWebhooks.secretAnnotations.

  • New default values in values.yaml:
    admissionWebhooks:
      secretAnnotations:
        "helm.sh/hook": "pre-install,pre-upgrade"
        "helm.sh/hook-delete-policy": "before-hook-creation"
  • Breaking change:
    If you previously set custom annotations, you must now merge them with the new default to maintain prior behavior:
    admissionWebhooks:
      secretAnnotations:
        "helm.sh/hook": "pre-install,pre-upgrade"
        "helm.sh/hook-delete-policy": "before-hook-creation"
        {your_custom_annotations}
  • Why this matters:
    This ensures user-supplied TLS files are validated to exist and be accessible early (pre-install or pre-upgrade), reducing the risk of errors in the Helm install phase.
@jvoravong
Copy link
Contributor Author

Please assign to me when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:operator Issue related to opentelemetry-operator helm chart
Projects
None yet
Development

No branches or pull requests

2 participants