Skip to content

[contribfest] Address FIXME in BaggageCodec #7235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
breedx-splk opened this issue Apr 2, 2025 · 3 comments
Open

[contribfest] Address FIXME in BaggageCodec #7235

breedx-splk opened this issue Apr 2, 2025 · 3 comments
Assignees
@rlacksgus97
Labels
contribfest

Comments

@breedx-splk
Copy link
Contributor

There is a FIXME comment in the BaggageCodec class, which is intended to instruct developers to circle back and guard against the ArrayIndexOutOfBoundsException from being thrown.

We should add a guard and ensure that the tests that expect the AIOOB are changed to reflect this.
@breedx-splk breedx-splk reopened this Apr 2, 2025
@rlacksgus97
Copy link

I'm working on it

@breedx-splk
Copy link
Contributor Author

@rlacksgus97 thanks for joining us at contribfest last week! I think I remember this being close. Any updates?

@rlacksgus97
Copy link

@breedx-splk Sorry for the late. I just have updated my PR.
#7239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlacksgus97 rlacksgus97

Labels
contribfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlacksgus97 @breedx-splk