-
Notifications
You must be signed in to change notification settings - Fork 569
Support first contentful paint event in document load plugin #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @pkanal @martinkuba (component owners) |
This instrumentation is not indicative of the direction the client/browser SIG is planning to go. It will be rewritten when there is a good specification for browser events. This work is ongoing but I don't think this instrumentation is likely to get any real enhancements before then. |
Why can't we set up an asynchronous task (e.g., with a 3-second delay) to collect the network spans, even if we can't guarantee that FCP has occurred by then? For example, we could set a timeout of 3 seconds, and if after that time we still haven't collected the data, it would indicate an inherent issue with the page itself. |
be like this |
What happened?
What happened?
What happened?
Steps to Reproduce
use like this in my react app
Expected Result
document load span whith 11 events
Actual Result
document load span whith 9 events
Additional Details
After a meticulous investigation, I have identified several potential causes that lead to this issue. when executing
otperformance is always an empty array. I realize that this can only be achieved through asynchronous retrieval.
the code is located here
opentelemetry-js-contrib/plugins/web/opentelemetry-instrumentation-document-load/src/instrumentation.ts
Line 208 in 1eb7700
by the way, why wasn't there a distinction between node and browser when introducing the platform in opentelemetry-core?
The text was updated successfully, but these errors were encountered: