Skip to content

Commit a46b66e

Browse files
tsloughterjsuereth
andauthoredMar 28, 2025··
remove comment on each profile service about keeping the RPC alive (#637)
Tigran explained this comment was likely a hold over from the OpenCensus protobufs which did use streaming RPC's. Unary RPC's, which are used by the OpenTelemetry protocol, can not be kept alive making the comment out of place. Co-authored-by: Josh Suereth <Joshua.Suereth@gmail.com>
1 parent e4fd4f6 commit a46b66e

File tree

4 files changed

+0
-8
lines changed

4 files changed

+0
-8
lines changed
 

‎opentelemetry/proto/collector/logs/v1/logs_service.proto

-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ option go_package = "go.opentelemetry.io/proto/otlp/collector/logs/v1";
2828
// OpenTelemetry and an collector, or between an collector and a central collector (in this
2929
// case logs are sent/received to/from multiple Applications).
3030
service LogsService {
31-
// For performance reasons, it is recommended to keep this RPC
32-
// alive for the entire life of the application.
3331
rpc Export(ExportLogsServiceRequest) returns (ExportLogsServiceResponse) {}
3432
}
3533

‎opentelemetry/proto/collector/metrics/v1/metrics_service.proto

-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ option go_package = "go.opentelemetry.io/proto/otlp/collector/metrics/v1";
2828
// instrumented with OpenTelemetry and a collector, or between a collector and a
2929
// central collector.
3030
service MetricsService {
31-
// For performance reasons, it is recommended to keep this RPC
32-
// alive for the entire life of the application.
3331
rpc Export(ExportMetricsServiceRequest) returns (ExportMetricsServiceResponse) {}
3432
}
3533

‎opentelemetry/proto/collector/profiles/v1development/profiles_service.proto

-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ option go_package = "go.opentelemetry.io/proto/otlp/collector/profiles/v1develop
2727
// Service that can be used to push profiles between one Application instrumented with
2828
// OpenTelemetry and a collector, or between a collector and a central collector.
2929
service ProfilesService {
30-
// For performance reasons, it is recommended to keep this RPC
31-
// alive for the entire life of the application.
3230
rpc Export(ExportProfilesServiceRequest) returns (ExportProfilesServiceResponse) {}
3331
}
3432

‎opentelemetry/proto/collector/trace/v1/trace_service.proto

-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ option go_package = "go.opentelemetry.io/proto/otlp/collector/trace/v1";
2828
// OpenTelemetry and a collector, or between a collector and a central collector (in this
2929
// case spans are sent/received to/from multiple Applications).
3030
service TraceService {
31-
// For performance reasons, it is recommended to keep this RPC
32-
// alive for the entire life of the application.
3331
rpc Export(ExportTraceServiceRequest) returns (ExportTraceServiceResponse) {}
3432
}
3533

0 commit comments

Comments
 (0)
Please sign in to comment.