Skip to content

make record_exception api consistent #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dubloom opened this issue Apr 10, 2025 · 0 comments
Open

make record_exception api consistent #4541

dubloom opened this issue Apr 10, 2025 · 0 comments

Comments

@dubloom
Copy link

dubloom commented Apr 10, 2025

Is your feature request related to a problem?

Each language api has a different function signature for record_exception.
The common base is having exception and attributes as function parameters. Java and Ruby have only these two which I do believe is the right version.

In Python however, we have additional parameters: timestamp and escaped. Now, escaped appears nowhere in the documentation. The timestamp parameter is more debatable but for the sake of consistency, I would argue in favor of deleting it as well.

Describe the solution you'd like

Remove timestamp and escaped from the record_exception function signature. If it accepted, I would like to do the same in the javascript api.

Describe alternatives you've considered

No response

Additional Context

No response

Would you like to implement a fix?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant