Skip to content

Commit 1d1f03d

Browse files
committed
test: add unit tests.
1 parent 5ba391d commit 1d1f03d

File tree

1 file changed

+13
-7
lines changed
  • opentelemetry-jaeger/src/exporter/config

1 file changed

+13
-7
lines changed

opentelemetry-jaeger/src/exporter/config/mod.rs

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -191,11 +191,13 @@ fn build_config_and_process(
191191

192192
#[cfg(test)]
193193
mod tests {
194+
use std::env;
194195
use crate::exporter::config::build_config_and_process;
195196
use opentelemetry::sdk::trace::Config;
196197
use opentelemetry::sdk::Resource;
197198
use opentelemetry::KeyValue;
198199
use std::sync::Arc;
200+
use crate::new_agent_pipeline;
199201

200202
#[test]
201203
fn test_set_service_name() {
@@ -241,13 +243,17 @@ mod tests {
241243
KeyValue::new("service.name", "override_service")
242244
);
243245

244-
// todo: move it to a separate test function
245-
// // OTEL_SERVICE_NAME env var also works
246-
// env::set_var("OTEL_SERVICE_NAME", "test service");
247-
// builder = crate::PipelineBuilder::default();
248-
// let exporter = builder.init_sync_exporter().unwrap();
249-
// assert_eq!(exporter.process.service_name, "test service");
250-
// env::set_var("OTEL_SERVICE_NAME", "")
246+
247+
}
248+
249+
#[test]
250+
fn test_read_from_env() {
251+
// OTEL_SERVICE_NAME env var also works
252+
env::set_var("OTEL_SERVICE_NAME", "test service");
253+
let builder = new_agent_pipeline();
254+
let exporter = builder.build_sync_agent_exporter().unwrap();
255+
assert_eq!(exporter.process.service_name, "test service");
256+
env::set_var("OTEL_SERVICE_NAME", "")
251257
}
252258
}
253259

0 commit comments

Comments
 (0)