Skip to content

Commit 332bd18

Browse files
authored
opentelemetry-jaeger: let with_agent_endpoint handle parsing of agent endpoint when set via env. (#448)
1 parent cac9893 commit 332bd18

File tree

1 file changed

+1
-4
lines changed
  • opentelemetry-jaeger/src/exporter

1 file changed

+1
-4
lines changed

opentelemetry-jaeger/src/exporter/env.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
use crate::PipelineBuilder;
22
use std::env;
3-
use std::net;
43

54
/// The name under which Jaeger will group reported spans.
65
const ENV_SERVICE_NAME: &str = "OTEL_SERVICE_NAME";
@@ -33,9 +32,7 @@ pub(crate) fn assign_attrs(mut builder: PipelineBuilder) -> PipelineBuilder {
3332
}
3433

3534
if let (Ok(host), Ok(port)) = (env::var(ENV_AGENT_HOST), env::var(ENV_AGENT_PORT)) {
36-
if let Ok(addr) = format!("{}:{}", host.trim(), port.trim()).parse::<net::SocketAddr>() {
37-
builder = builder.with_agent_endpoint(addr);
38-
}
35+
builder = builder.with_agent_endpoint(format!("{}:{}", host.trim(), port.trim()));
3936
}
4037

4138
#[cfg(feature = "collector_client")]

0 commit comments

Comments
 (0)