fix: fix trace id in logs when nested in tracing span with set_parent

Author: SF-Zhou

opentelemetry-appender-tracing/Cargo.toml

@@ -34,7 +34,7 @@ tokio = { workspace = true, features = ["full"]}
 pprof = { version = "0.14", features = ["flamegraph", "criterion"] }
 
 [features]
-default = []
+default = ["experimental_use_tracing_span_context"]
 experimental_metadata_attributes = ["dep:tracing-log"]
 spec_unstable_logs_enabled = ["opentelemetry/spec_unstable_logs_enabled"]
 experimental_use_tracing_span_context = ["tracing-opentelemetry"]

opentelemetry-appender-tracing/src/layer.rs

@@ -246,21 +246,24 @@ where
 
         #[cfg(feature = "experimental_use_tracing_span_context")]
         if let Some(span) = _ctx.event_span(event) {
+            use opentelemetry::trace::TraceContextExt;
             use tracing_opentelemetry::OtelData;
-            let opt_span_id = span
-                .extensions()
-                .get::<OtelData>()
-                .and_then(|otd| otd.builder.span_id);
-
-            let opt_trace_id = span.scope().last().and_then(|root_span| {
-                root_span
-                    .extensions()
-                    .get::<OtelData>()
-                    .and_then(|otd| otd.builder.trace_id)
-            });
-
-            if let Some((trace_id, span_id)) = opt_trace_id.zip(opt_span_id) {
-                log_record.set_trace_context(trace_id, span_id, None);
+            if let Some(otd) = span.extensions().get::<OtelData>() {
+                if let Some(span_id) = otd.builder.span_id {
+                    let opt_trace_id = if otd.parent_cx.has_active_span() {
+                        Some(otd.parent_cx.span().span_context().trace_id())
+                    } else {
+                        span.scope().last().and_then(|root_span| {
+                            root_span
+                                .extensions()
+                                .get::<OtelData>()
+                                .and_then(|otd| otd.builder.trace_id)
+                        })
+                    };
+                    if let Some(trace_id) = opt_trace_id {
+                        log_record.set_trace_context(trace_id, span_id, None);
+                    }
+                }
             }
         }
 
@@ -611,7 +614,9 @@ mod tests {
     #[cfg(feature = "experimental_use_tracing_span_context")]
     #[test]
     fn tracing_appender_inside_tracing_crate_context() {
+        use opentelemetry::{trace::SpanContext, Context, SpanId, TraceId};
         use opentelemetry_sdk::trace::InMemorySpanExporterBuilder;
+        use tracing_opentelemetry::OpenTelemetrySpanExt;
 
         // Arrange
         let exporter: InMemoryLogExporter = InMemoryLogExporter::default();
@@ -637,8 +642,23 @@ mod tests {
         // Avoiding global subscriber.init() as that does not play well with unit tests.
         let _guard = tracing::subscriber::set_default(subscriber);
 
+        // Set context from remote.
+        let remote_trace_id = TraceId::from_u128(233);
+        let remote_span_id = SpanId::from_u64(2333);
+        let remote_span_context = SpanContext::new(
+            remote_trace_id,
+            remote_span_id,
+            TraceFlags::SAMPLED,
+            true,
+            Default::default(),
+        );
+
         // Act
         tracing::error_span!("outer-span").in_scope(|| {
+            let span = tracing::Span::current();
+            let parent_context = Context::current().with_remote_span_context(remote_span_context);
+            span.set_parent(parent_context);
+
             error!("first-event");
 
             tracing::error_span!("inner-span").in_scope(|| {
@@ -655,6 +675,7 @@ mod tests {
         assert_eq!(spans.len(), 2);
 
         let trace_id = spans[0].span_context.trace_id();
+        assert_eq!(trace_id, remote_trace_id);
         assert_eq!(trace_id, spans[1].span_context.trace_id());
         let inner_span_id = spans[0].span_context.span_id();
         let outer_span_id = spans[1].span_context.span_id();