Skip to content

Commit ac74d94

Browse files
committed
test: add unit tests.
1 parent 5ba391d commit ac74d94

File tree

1 file changed

+11
-7
lines changed
  • opentelemetry-jaeger/src/exporter/config

1 file changed

+11
-7
lines changed

opentelemetry-jaeger/src/exporter/config/mod.rs

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,11 @@ fn build_config_and_process(
192192
#[cfg(test)]
193193
mod tests {
194194
use crate::exporter::config::build_config_and_process;
195+
use crate::new_agent_pipeline;
195196
use opentelemetry::sdk::trace::Config;
196197
use opentelemetry::sdk::Resource;
197198
use opentelemetry::KeyValue;
199+
use std::env;
198200
use std::sync::Arc;
199201

200202
#[test]
@@ -240,14 +242,16 @@ mod tests {
240242
process.tags[0],
241243
KeyValue::new("service.name", "override_service")
242244
);
245+
}
243246

244-
// todo: move it to a separate test function
245-
// // OTEL_SERVICE_NAME env var also works
246-
// env::set_var("OTEL_SERVICE_NAME", "test service");
247-
// builder = crate::PipelineBuilder::default();
248-
// let exporter = builder.init_sync_exporter().unwrap();
249-
// assert_eq!(exporter.process.service_name, "test service");
250-
// env::set_var("OTEL_SERVICE_NAME", "")
247+
#[test]
248+
fn test_read_from_env() {
249+
// OTEL_SERVICE_NAME env var also works
250+
env::set_var("OTEL_SERVICE_NAME", "test service");
251+
let builder = new_agent_pipeline();
252+
let exporter = builder.build_sync_agent_exporter().unwrap();
253+
assert_eq!(exporter.process.service_name, "test service");
254+
env::set_var("OTEL_SERVICE_NAME", "")
251255
}
252256
}
253257

0 commit comments

Comments
 (0)