Skip to content

[Metrics] Revisit every public Error enums and Results #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cijothomas opened this issue Jan 25, 2025 · 2 comments
Closed

[Metrics] Revisit every public Error enums and Results #2564

cijothomas opened this issue Jan 25, 2025 · 2 comments

Comments

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/metrics/error.rs#L13 defines pub enums that consist of errors from a variety of scenarios. The same is used as return type for export(), flush(), shutdown() methods, and also for internal validation methods for Views.

Must redesign this to ensure specific Error types are used for each methods.

Already discussed similar idea in #2381, but this issue is specifically for fixing Metrics.

@cijothomas
Copy link
Member Author

The MeterProvider/Reader/Exporter is modified to use the newly added https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/error.rs

Views uses different one, that need to addressed before stabilizing it.
Additionally OTLP Exporter builder() also need modifications to the Result it returns.
Given the core work is completed, removing from 0.28 milestone..

@cijothomas cijothomas modified the milestones: 0.28.0, Metrics SDK Stable Feb 6, 2025
@cijothomas
Copy link
Member Author

#2905
#2928
#2906

These PRs did the most cleanup. Only remaining item is the struct passed to exporters, which is being refactored here: #2921

Closing as there is no pending tasks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant