Switch users to opencontainers/cgroups #5
Comments
This comment has been minimized.
This comment has been minimized.
kolyshkin
added a commit
to kolyshkin/cri-o
that referenced
this issue
Apr 15, 2025
Switch from opencontainers/runc/libcontainer/cgroups to opencontainers/cgroups. This used to be part of runc but is living in a separate repo now, as per [1]. This also does two things which deserve some explanation: 1. The new code no longer use containers/common/pkg/cgroups to add conmon pid to conmon cgroup. This might be a breaking change because the containers/common/pkg/cgroups implementation does not actually add the pid to the cgroup for cgroup v2 (see [2]; it is a mystery to me as to why), while the opencontainers/cgroups implementation does. 2. Move/remove a long comment preceding control.AddPid, because over time it become detached from the reality of the code: * part of the comment being removed was added by commit a2d4476 but then it was moved to a wrong place by commit 058d6b9 -- let's move it to a proper place; * another part of the comment being removed was added by commit 29121c8; I don't think it makes sense to keep it. Related to opencontainers/cgroups#5. [1]: https://github.com/opencontainers/tob/blob/main/proposals/cgroups.md [2]: https://github.com/containers/common/blob/e8ccfbf9d99/pkg/cgroups/cgroups_linux.go#L497-L504 Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is to merely track the progress of switching users from github.com/opencontainers/runc/libcontainer/cgroups to github.com/opencontainers/cgroups.
The text was updated successfully, but these errors were encountered: