Skip to content

Commit af7edd8

Browse files
committed
chore: remove husky 🪓🐶
We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/[email protected] prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: openedx/frontend-app-learning#1622
1 parent 9323f11 commit af7edd8

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

package-lock.json

Lines changed: 0 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919
"dev": "PUBLIC_PATH=/authn/ MFE_CONFIG_API_URL='http://localhost:8000/api/mfe_config/v1' fedx-scripts webpack-dev-server --progress --host apps.local.openedx.io",
2020
"test": "fedx-scripts jest --coverage --passWithNoTests"
2121
},
22-
"husky": {
23-
"hooks": {
24-
"pre-commit": "npm run lint"
25-
}
26-
},
2722
"author": "edX",
2823
"license": "AGPL-3.0",
2924
"homepage": "https://github.com/openedx/frontend-app-authn#readme",
@@ -79,7 +74,6 @@
7974
"eslint-plugin-import": "2.31.0",
8075
"glob": "7.2.3",
8176
"history": "5.3.0",
82-
"husky": "9.1.7",
8377
"jest": "29.7.0",
8478
"react-test-renderer": "^18.3.1"
8579
}

0 commit comments

Comments
 (0)