Skip to content

Commit f868076

Browse files
authored
VS remove the check for including folders (#616)
1 parent 9783559 commit f868076

File tree

3 files changed

+11
-32
lines changed

3 files changed

+11
-32
lines changed

commandLine/src/defines.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#define OFPROJECTGENERATOR_MAJOR_VERSION "0"
2-
#define OFPROJECTGENERATOR_MINOR_VERSION "93"
2+
#define OFPROJECTGENERATOR_MINOR_VERSION "94"
33
#define OFPROJECTGENERATOR_PATCH_VERSION "0"
44

55
#define PG_VERSION (OFPROJECTGENERATOR_MAJOR_VERSION "." OFPROJECTGENERATOR_MINOR_VERSION "." OFPROJECTGENERATOR_PATCH_VERSION)

commandLine/src/projects/visualStudioProject.cpp

+3-7
Original file line numberDiff line numberDiff line change
@@ -669,13 +669,9 @@ void visualStudioProject::addAddonIncludePaths(const ofAddon& addon) {
669669
addInclude(dir.string());
670670
} else{
671671
fs::path normalizedDir = normalizePath(dir);
672-
if (containsSourceFiles(normalizedDir)) {
673-
normalizedDir = makeRelative(projectDir, dir);
674-
ofLogVerbose() << "[vsproject]-uniqueIncludeDirs] contains src - Adding dir:: [" << normalizedDir.string() << "]";
675-
addInclude(normalizedDir);
676-
} else {
677-
ofLogVerbose() << "[vsproject]-uniqueIncludeDirs] no src - not adding [" << normalizedDir.string() << "]";
678-
}
672+
normalizedDir = makeRelative(projectDir, dir);
673+
ofLogVerbose() << "[vsproject]-uniqueIncludeDirs] Adding dir:: [" << normalizedDir.string() << "]";
674+
addInclude(normalizedDir);
679675
}
680676
}
681677
}

commandLine/src/projects/xcodeProject.cpp

+7-24
Original file line numberDiff line numberDiff line change
@@ -825,32 +825,15 @@ string xcodeProject::addFile(const fs::path & path, const fs::path & folder, con
825825
}
826826
}
827827

828-
// needed or the same?
829-
// if (fp.linkBinaryWithLibraries) { // Link Binary With Libraries
830-
// addCommand("# --- linkBinaryWithLibraries");
831-
// addCommand("Add :objects:" + uuidMap["linkBinaryWithLibraries"] + ":files: string " + buildUUID);
832-
// alert (commands.back(), 95);
833-
// }
834-
835-
// if (fp.frameworksBuildPhase) { // Link Binary With Libraries
836828
if (fp.linkBinaryWithLibraries) { // Link Binary With Libraries
837-
auto tempUUID = generateUUID(ofPathToString(path) + "-InFrameworks");
838-
addCommand("Add :objects:" + tempUUID + ":fileRef string " + UUID);
839-
addCommand("Add :objects:" + tempUUID + ":isa string PBXBuildFile");
840-
addCommand("# --- linkBinaryWithLibraries PBXFrameworksBuildPhase");
841-
// uuidMap["linkBinaryWithLibraries"] = "E4B69B590A3A1756003C02F2";
842-
addCommand("Add :objects:" + uuidMap["linkBinaryWithLibraries"] + ":files: string " + tempUUID);
843-
alert (commands.back(), 96);
829+
auto tempUUID = generateUUID(ofPathToString(path) + "-InFrameworks");
830+
addCommand("Add :objects:" + tempUUID + ":fileRef string " + UUID);
831+
addCommand("Add :objects:" + tempUUID + ":isa string PBXBuildFile");
832+
addCommand("# --- linkBinaryWithLibraries PBXFrameworksBuildPhase");
833+
// uuidMap["linkBinaryWithLibraries"] = "E4B69B590A3A1756003C02F2";
834+
addCommand("Add :objects:" + uuidMap["linkBinaryWithLibraries"] + ":files: string " + tempUUID);
835+
alert (commands.back(), 96);
844836
}
845-
846-
847-
// if ( path.extension() == ".framework" || path.extension() == ".xcframework" ) {
848-
// addCommand("# ---- Frameworks Folder " + UUID);
849-
// addCommand("Add :objects:901808C02053638E004A7774:children: string " + UUID);
850-
851-
// addCommand("# ---- PBXFrameworksBuildPhase " + buildUUID);
852-
// addCommand("Add :objects:1D60588F0D05DD3D006BFB54:files: string " + buildUUID);
853-
// }
854837
}
855838
return UUID;
856839
}

0 commit comments

Comments
 (0)