reinterpret_cast<> asserts

Author: jdksjolen

src/hotspot/share/classfile/classFileParser.cpp

@@ -3289,7 +3289,7 @@ void ClassFileParser::parse_classfile_bootstrap_methods_attribute(const ClassFil
   // representing bootstrap specifiers:
   //    length*{bootstrap_method_index, argument_count, argument_count*{argument_index}}
   const u4 attribute_tail_length = attribute_byte_length - static_cast<u4>(sizeof(u2));
-
+  assert(attribute_tail_length % sizeof(u2) == 0, "");
   Array<u4>* const offsets =
     MetadataFactory::new_array<u4>(_loader_data, num_bootstrap_methods, CHECK);
   Array<u2>* const entries =  // u2 data holding all the BSM attribute entries

src/hotspot/share/oops/constantPool.hpp

@@ -104,9 +104,9 @@ class BSMAttributeEntry {
   // how to locate one of these inside a packed u2 data array:
   static BSMAttributeEntry* entry_at_offset(Array<u2>* entries, int offset) {
     assert(0 <= offset && offset+1 < entries->length(), "oob-1");
-    // do not bother to copy u2 data; just overlay the struct within the array
-    BSMAttributeEntry* bsme = (BSMAttributeEntry*)entries->adr_at(offset);
-    assert(offset+1+bsme->argument_count() <= entries->length(), "oob-2");
+    // Overlay the struct within the array
+    BSMAttributeEntry* bsme = reinterpret_cast<BSMAttributeEntry*>(entries->adr_at(offset));
+    assert(offset+1+bsme->argument_count() < entries->length(), "oob-2");
     return bsme;
   }
   friend class ConstantPool;  // uses entry_at_offset