8289: Remove security manager related code

Reviewed-by: aptmac

Author: thegreystone

application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/testutil/JVMKeepAlive.java

@@ -35,8 +35,6 @@
 import java.io.IOException;
 import java.net.DatagramPacket;
 import java.net.DatagramSocket;
-import java.security.AccessController;
-import java.security.PrivilegedAction;
 
 /**
  * Simple, small test class to make a JVM stay awake. Takes one optional argument, which is the
@@ -63,12 +61,7 @@ public class JVMKeepAlive {
 	private static class JVMKeepAliveSlayer implements Runnable {
 		@Override
 		public void run() {
-			String portStr = AccessController.doPrivileged(new PrivilegedAction<String>() {
-				@Override
-				public String run() {
-					return System.getProperty(PROPERTY_KILL_PORT, String.valueOf(DEFAULT_KILL_PORT));
-				}
-			});
+			String portStr = System.getProperty(PROPERTY_KILL_PORT, String.valueOf(DEFAULT_KILL_PORT));
 
 			int port = 0;
 			try {

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/security/SecurityManagerFactory.java

@@ -52,7 +52,7 @@ public final class SecurityManagerFactory {
 		try {
 			if (className != null) {
 				Class<? extends Object> c = Class.forName(className);
-				instance = (ISecurityManager) c.newInstance();
+				instance = (ISecurityManager) c.getDeclaredConstructor().newInstance();
 			}
 		} catch (Exception e) {
 			LOGGER.log(Level.SEVERE, "Could not create Security manager for className. Using default! Exception was:", //$NON-NLS-1$

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/JfrReportPermission.java

@@ -87,25 +87,13 @@
 public class JfrRulesReport {
 
 	private static final Map<String, String> TRANSFORMS = new LinkedHashMap<>();
-	private static final JfrReportPermission OVERRIDE_PERMISSION = new JfrReportPermission("override"); //$NON-NLS-1$
 
 	static {
 		TRANSFORMS.put("html", "org/openjdk/jmc/flightrecorder/rules/report/html.xslt"); //$NON-NLS-1$ //$NON-NLS-2$
 		TRANSFORMS.put("text", "org/openjdk/jmc/flightrecorder/rules/report/text.xslt"); //$NON-NLS-1$ //$NON-NLS-2$
 		TRANSFORMS.put("json", "org/openjdk/jmc/flightrecorder/rules/report/json.xslt"); //$NON-NLS-1$ //$NON-NLS-2$
 	}
 
-	private static void checkAccess(JfrReportPermission p) throws SecurityException {
-		SecurityManager sm = System.getSecurityManager();
-		if (sm != null) {
-			sm.checkPermission(p);
-		}
-	}
-
-	private static void checkOverrideAccess() throws SecurityException {
-		checkAccess(OVERRIDE_PERMISSION);
-	}
-
 	public static void main(String[] args) throws ParserConfigurationException, TransformerException {
 		if (args.length == 0) {
 			System.out.println("Enter one or more JDK Flight Recorder file names as arguments to this program."); //$NON-NLS-1$
@@ -201,8 +189,6 @@ public static void printReport(
 				String xsltResourceName = TRANSFORMS.get(formatName);
 				if (xsltResourceName != null) {
 					if (override) {
-						// Must prevent unauthorized injection of potentially dangerous XSLTs.
-						checkOverrideAccess();
 						xsltResourceStream = Thread.currentThread().getContextClassLoader()
 								.getResourceAsStream(xsltResourceName);
 					} else {