Check we are not creating repo in kube* or openshift* namespaces with tkn pac repo create

[chmouel]

this has some unexpected behaviour where the default SA would not be available anymore! and it's probably bad practice to create "workload" in system namespaces...

[sm43]

we warn to WARN right? and not decline the request

[chmouel]

I think it was reported as not working when creating there since we don't auto create the service account in there

[sm43]

in case of openshift, denying might be okay openshift-* namespaces but
in case of kube, we probably just WARN and create if user says YES.

[chmouel]

sure! i just add kube-* for completeness to be honest...

[PuneetPunamiya]

So current behavior is

$ tkn pac create repo 
? Enter the Git repository url (default: https://github.com/PuneetPunamiya/pac-demo):  
? Please enter the namespace where the pipeline should run (default: pac-demo-pipelines): kube-puneet
! Namespace kube-puneet is not found
? Would you like me to create the namespace kube-puneet? Yes
✓ Repository puneetpunamiya-pac-demo has been created in kube-puneet namespace
ℹ Directory .tekton has been created.
✓ We have detected your repository using the programming language Go.
✓ A basic template has been created in /home/ppunamiy/pac-demo/.tekton/pipelinerun.yaml, feel free to customize it.
ℹ You can test your pipeline by pushing the generated template to your git repository

And expected behavior is

../openshift-pipelines/pipelines-as-code/tkn-pac create repo 
? Enter the Git repository url (default: https://github.com/PuneetPunamiya/pac-demo):  
? Please enter the namespace where the pipeline should run (default: pac-demo-pipelines): kube-
! Namespace kube- is not found
! Warning: Namespace kube- has prefix kube-       <---
? Would you like me to create the namespace kube-? (Y/n) 

And in case of openshift* we just return and exit ?

[chmouel]

I am not sure why it i said it would not work in kube-* projects but i am pretty it would not work only when creating it in openshift-pipelines or tektoncd-pipelines, so at least start with that (try it yourself and see if running a pipelinerun from those namespace works or not, maybe it has been fixed since then)