Skip to content

Commit f80c0a6

Browse files
committed
WIP
Signed-off-by: Jeff Mesnil <[email protected]>
1 parent 7f4fb20 commit f80c0a6

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

exporter/test/e2e/jboss_eap_test.go

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,18 @@ func TestJBossEAP_8_0(t *testing.T) {
106106
Setup(deployTestHelmRelease(appName)).
107107
Teardown(undeployTestHelmRelease(appName)).
108108
Assess("runtime info extracted", checkExtractedRuntimeInfo(namespace, "app.kubernetes.io/name="+appName, appName, func(g *Ω.WithT, runtimeInfo types.ContainerRuntimeInfo) {
109-
g.Expect(runtimeInfo.Os).Should(Ω.Equal("rhel"))
110-
g.Expect(runtimeInfo.OsVersion).Should(Ω.Equal("8.10"))
111-
g.Expect(runtimeInfo.Kind).Should(Ω.Equal("Java"))
112-
g.Expect(runtimeInfo.KindVersion).Should(Ω.HavePrefix("17.0"))
113-
g.Expect(runtimeInfo.KindImplementer).Should(Ω.Equal("Red Hat, Inc."))
114-
115-
g.Expect(len(runtimeInfo.Runtimes)).Should(Ω.Equal(1))
116-
runtime := runtimeInfo.Runtimes[0]
117-
g.Expect(runtime.Name).Should(Ω.Equal("Red Hat JBoss Enterprise Application Platform"))
118-
g.Expect(runtime.Version).Should(Ω.Equal("8.0 Update 6.1"))
109+
expected := types.ContainerRuntimeInfo{
110+
Os: "rhel",
111+
OsVersion: "8.10",
112+
Kind: "Java",
113+
KindVersion: "17.0.14",
114+
KindImplementer: "Red Hat, Inc.",
115+
Runtimes: []types.RuntimeComponent{{
116+
Name: "Red Hat JBoss Enterprise Application Platform",
117+
Version: "8.0 Update 6.1",
118+
}},
119+
}
120+
g.Expect(runtimeInfo).Should(Ω.Equal(expected))
119121
}))
120122
_ = testenv.Test(t, feature.Feature())
121123
}
@@ -131,6 +133,7 @@ func deployTestHelmRelease(appName string) func(context.Context, *testing.T, *en
131133
helm.WithArgs("--set", "build.uri=https://github.com/jmesnil/insights-runtime-extractor"),
132134
helm.WithArgs("--set", "build.contextDir=runtime-samples/jboss-eap/8.0"),
133135
helm.WithArgs("--set", "build.ref=fix_eap_version_in_test"),
136+
helm.WithArgs("--set", "build.s2i.jkd17.runtimeImage=registry.redhat.io/jboss-eap-8/eap8-openjdk17-runtime-openshift-rhel8@sha256:d16346922c00c0430b3a3a6b3a47c910a23063a8a679a5c1b2d32fd96b92a225"),
134137
); err != nil {
135138
g.Expect(err).ShouldNot(Ω.HaveOccurred())
136139
}

0 commit comments

Comments
 (0)