clusterquota: Account for Istio configmaps

Add a workaround for OSSM 3.0.0, which includes a version of Istio that creates
a configmap in every namespace.  This configmap throws off the accounting used
in verifying the behavior of ClusterResourceQuota.  This commit adds an
adjustment to this accounting when the Istio configmap is found.

This commit is related to OCPBUGS-54884.

https://issues.redhat.com/browse/OCPBUGS-54884

* test/extended/quota/clusterquota.go: Add workaround for Istio.

Author: Miciah

Diff for: test/extended/quota/clusterquota.go

@@ -126,6 +126,55 @@ var _ = g.Describe("[sig-api-machinery][Feature:ClusterResourceQuota]", func() {
 			configmap := &corev1.ConfigMap{}
 			configmap.GenerateName = "test"
 			if _, err := clusterAdminKubeClient.CoreV1().ConfigMaps(firstProjectName).Create(context.Background(), configmap, metav1.CreateOptions{}); err != nil {
+				// Istio sometimes create an additional configmap in each namespace, so account for it
+				// and retry.
+				//
+				// Note that the tests that install Istio run in parallel with this test, so we cannot
+				// assume that it has or has not created the configmap when we create the quota.  Thus
+				// we must check here whether the reason we got an error was because this configmap
+				// put us over the quota.
+				//
+				// TODO: Remove the following const and if/else block when we bump to OSSM 3.0.1, which
+				// ships a version of Istio that has been patched not to create these configmaps.
+				const istioConfigmapName = "istio-ca-root-cert"
+				if _, err := clusterAdminKubeClient.CoreV1().ConfigMaps(firstProjectName).Get(context.Background(), istioConfigmapName, metav1.GetOptions{}); err != nil {
+					if !apierrors.IsNotFound(err) {
+						// Use t.Error here so as to fall through to the t.Fatal below.
+						t.Errorf("unexpected error: %v", err)
+					}
+					// The Istio configmap doesn't exist, and therefore The Create must have failed
+					// for some other reason; fall through to the t.Fatal for the outer err.
+				} else {
+					// As the Istio configmap exists in this project, assume that it exists in all
+					// projects, and adjust the clusterquota accordingly.
+					namespaceInitialCMCount++
+					adjustedMandatoryCMQuantity := resource.NewQuantity(int64(namespaceInitialCMCount)*2, resource.DecimalSI)
+					if quota, err := clusterAdminQuotaClient.QuotaV1().ClusterResourceQuotas().Get(context.Background(), cq.Name, metav1.GetOptions{}); err != nil {
+						t.Fatalf("unexpected error: %v", err)
+					} else {
+						cq = quota
+					}
+					q := cq.Spec.Quota.Hard[corev1.ResourceConfigMaps]
+					q.Sub(*mandatoryCMQuantity)
+					q.Add(*adjustedMandatoryCMQuantity)
+					cq.Spec.Quota.Hard[corev1.ResourceConfigMaps] = q
+					if _, err := clusterAdminQuotaClient.QuotaV1().ClusterResourceQuotas().Update(context.Background(), cq, metav1.UpdateOptions{}); err != nil {
+						t.Fatalf("unexpected error: %v", err)
+					}
+					if err := waitForQuotaStatus(clusterAdminQuotaClient, cq.Name, func(quota *quotav1.ClusterResourceQuota) error {
+						if !equality.Semantic.DeepEqual(quota.Spec.Quota.Hard, quota.Status.Total.Hard) {
+							return fmt.Errorf("%#v != %#v", quota.Spec.Quota.Hard, quota.Status.Total.Hard)
+						}
+						return nil
+					}); err != nil {
+						t.Fatalf("unexpected error: %v", err)
+					}
+
+					// Retry creating the configmap with the quota adjusted for the Istio configmap.
+					if _, err := clusterAdminKubeClient.CoreV1().ConfigMaps(firstProjectName).Create(context.Background(), configmap, metav1.CreateOptions{}); err != nil {
+						t.Fatalf("unexpected error: %v", err)
+					}
+				}
 				t.Fatalf("unexpected error: %v", err)
 			}
 			if err := waitForQuotaStatus(clusterAdminQuotaClient, cq.Name, func(quota *quotav1.ClusterResourceQuota) error {