Skip to content

Commit 0f2c04c

Browse files
committed
wip
1 parent 51f07d5 commit 0f2c04c

File tree

3 files changed

+34
-7
lines changed

3 files changed

+34
-7
lines changed

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ lto = "thin"
105105

106106
[workspace.dependencies]
107107
# Stark Backend
108-
openvm-stark-backend = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.0.0", default-features = false }
109-
openvm-stark-sdk = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.0.0", default-features = false }
108+
openvm-stark-backend = { git = "https://github.com/openvm-org/stark-backend.git", rev = "936ea9149831273284eefc642f5ff86bc0cb00cb", default-features = false }
109+
openvm-stark-sdk = { git = "https://github.com/openvm-org/stark-backend.git", rev = "936ea9149831273284eefc642f5ff86bc0cb00cb", default-features = false }
110110

111111
# OpenVM
112112
openvm-sdk = { path = "crates/sdk", default-features = false }

crates/sdk/src/codec.rs

Lines changed: 30 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@ use openvm_continuations::verifier::root::types::RootVmVerifierInput;
77
use openvm_native_compiler::ir::DIGEST_SIZE;
88
use openvm_native_recursion::hints::{InnerBatchOpening, InnerFriProof, InnerQueryProof};
99
use openvm_stark_backend::{
10-
config::{Com, PcsProof},
11-
interaction::{fri_log_up::FriLogUpPartialProof, RapPhaseSeqKind},
10+
config::{Com, PcsProof, RapPhaseSeqPartialProof},
11+
interaction::{
12+
fri_log_up::FriLogUpPartialProof, gkr_log_up::GkrLogUpPartialProof, RapPhaseSeqKind,
13+
},
1214
p3_field::{
1315
extension::BinomialExtensionField, FieldAlgebra, FieldExtensionAlgebra, PrimeField32,
1416
},
@@ -147,6 +149,11 @@ fn encode_opened_values<W: Write>(
147149
for phase in &opened_values.after_challenge {
148150
encode_slice(phase, writer)?;
149151
}
152+
todo!();
153+
// opened_values.extra_after_challenge.len().encode(writer)?;
154+
// for phase in &opened_values.extra_after_challenge {
155+
// encode_slice(phase, writer)?;
156+
// }
150157
opened_values.quotient.len().encode(writer)?;
151158
for per_air in &opened_values.quotient {
152159
per_air.len().encode(writer)?;
@@ -261,6 +268,12 @@ impl Encode for Option<FriLogUpPartialProof<F>> {
261268
}
262269
}
263270

271+
impl Encode for Option<GkrLogUpPartialProof<BinomialExtensionField<F, 4>, F>> {
272+
fn encode<W: Write>(&self, writer: &mut W) -> Result<()> {
273+
todo!()
274+
}
275+
}
276+
264277
impl Encode for Challenge {
265278
fn encode<W: Write>(&self, writer: &mut W) -> Result<()> {
266279
let base_slice: &[F] = self.as_base_slice();
@@ -392,7 +405,7 @@ impl Decode for Proof<SC> {
392405
}
393406

394407
// Decode logup witness
395-
let rap_phase_seq_proof = Option::<FriLogUpPartialProof<F>>::decode(reader)?;
408+
let rap_phase_seq_proof = Option::<RapPhaseSeqPartialProof<SC>>::decode(reader)?;
396409

397410
Ok(Proof {
398411
commitments,
@@ -443,6 +456,13 @@ fn decode_opened_values<R: Read>(reader: &mut R) -> Result<OpenedValues<Challeng
443456
after_challenge.push(decode_vec(reader)?);
444457
}
445458

459+
let extra_after_challenge_count = usize::decode(reader)?;
460+
let mut extra_after_challenge = Vec::with_capacity(extra_after_challenge_count);
461+
for _ in 0..after_challenge_count {
462+
todo!()
463+
// extra_after_challenge.push(decode_vec(reader)?);
464+
}
465+
446466
let quotient_count = usize::decode(reader)?;
447467
let mut quotient = Vec::with_capacity(quotient_count);
448468
for _ in 0..quotient_count {
@@ -458,6 +478,7 @@ fn decode_opened_values<R: Read>(reader: &mut R) -> Result<OpenedValues<Challeng
458478
preprocessed,
459479
main,
460480
after_challenge,
481+
extra_after_challenge,
461482
quotient,
462483
})
463484
}
@@ -566,6 +587,12 @@ impl Decode for Option<FriLogUpPartialProof<F>> {
566587
}
567588
}
568589

590+
impl Decode for Option<GkrLogUpPartialProof<BinomialExtensionField<F, 4>, F>> {
591+
fn decode<R: Read>(reader: &mut R) -> Result<Self> {
592+
todo!()
593+
}
594+
}
595+
569596
impl Decode for Challenge {
570597
fn decode<R: Read>(reader: &mut R) -> Result<Self> {
571598
// For a BinomialExtensionField<F, 4>, we need to read 4 F elements

0 commit comments

Comments
 (0)