Remove impl_field argument from guest-libs

Author: Avaneesh-axiom

guest-libs/ff_derive/guest/src/lib.rs

@@ -277,8 +277,7 @@ fn openvm_struct_impl(ast: &syn::ItemStruct, modulus: &BigUint) -> proc_macro2::
     quote! {
         ::openvm_algebra_moduli_macros::moduli_declare! {
             #struct_ident {
-                modulus = #modulus_str,
-                impl_field = true
+                modulus = #modulus_str
             }
         }
     }

guest-libs/k256/guest/src/internal.rs

@@ -21,8 +21,8 @@ pub const fn seven_le() -> [u8; 32] {
 }
 
 moduli_declare! {
-    Secp256k1Coord { modulus = "0xFFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFE FFFFFC2F", impl_field = true },
-    Secp256k1Scalar { modulus = "0xFFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFE BAAEDCE6 AF48A03B BFD25E8C D0364141", impl_field = true },
+    Secp256k1Coord { modulus = "0xFFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFE FFFFFC2F" },
+    Secp256k1Scalar { modulus = "0xFFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFE BAAEDCE6 AF48A03B BFD25E8C D0364141" },
 }
 
 sw_declare! {

guest-libs/p256/guest/src/internal.rs

@@ -14,8 +14,8 @@ use crate::P256;
 // --- Define the OpenVM modular arithmetic and ecc types ---
 
 moduli_declare! {
-    P256Coord { modulus = "0xffffffff00000001000000000000000000000000ffffffffffffffffffffffff", impl_field = true },
-    P256Scalar { modulus = "0xffffffff00000000ffffffffffffffffbce6faada7179e84f3b9cac2fc632551", impl_field = true },
+    P256Coord { modulus = "0xffffffff00000001000000000000000000000000ffffffffffffffffffffffff" },
+    P256Scalar { modulus = "0xffffffff00000000ffffffffffffffffbce6faada7179e84f3b9cac2fc632551" },
 }
 
 // from_const_bytes is little endian

guest-libs/pairing/guest/src/bls12_381/mod.rs

@@ -41,34 +41,6 @@ pub type Scalar = Bls12_381Scalar;
 pub type G1Affine = Bls12_381G1Affine;
 pub use g2::G2Affine;
 
-impl Field for Fp {
-    type SelfRef<'a> = &'a Self;
-    const ZERO: Self = <Self as IntMod>::ZERO;
-    const ONE: Self = <Self as IntMod>::ONE;
-
-    fn double_assign(&mut self) {
-        IntMod::double_assign(self);
-    }
-
-    fn square_assign(&mut self) {
-        IntMod::square_assign(self);
-    }
-}
-
-impl Field for Scalar {
-    type SelfRef<'a> = &'a Self;
-    const ZERO: Self = <Self as IntMod>::ZERO;
-    const ONE: Self = <Self as IntMod>::ONE;
-
-    fn double_assign(&mut self) {
-        IntMod::double_assign(self);
-    }
-
-    fn square_assign(&mut self) {
-        IntMod::square_assign(self);
-    }
-}
-
 // https://hackmd.io/@benjaminion/bls12-381#Cofactor
 // BLS12-381: The from_xy function will allow constructing elements that lie on the curve
 // but aren't actually in the cyclic subgroup of prime order that is usually called G1.

guest-libs/pairing/guest/src/bn254/mod.rs

@@ -42,34 +42,6 @@ pub type Scalar = Bn254Scalar;
 pub type G1Affine = Bn254G1Affine;
 pub use g2::G2Affine;
 
-impl Field for Fp {
-    type SelfRef<'a> = &'a Self;
-    const ZERO: Self = <Self as IntMod>::ZERO;
-    const ONE: Self = <Self as IntMod>::ONE;
-
-    fn double_assign(&mut self) {
-        IntMod::double_assign(self);
-    }
-
-    fn square_assign(&mut self) {
-        IntMod::square_assign(self);
-    }
-}
-
-impl Field for Scalar {
-    type SelfRef<'a> = &'a Self;
-    const ZERO: Self = <Self as IntMod>::ZERO;
-    const ONE: Self = <Self as IntMod>::ONE;
-
-    fn double_assign(&mut self) {
-        IntMod::double_assign(self);
-    }
-
-    fn square_assign(&mut self) {
-        IntMod::square_assign(self);
-    }
-}
-
 impl CyclicGroup for G1Affine {
     // https://eips.ethereum.org/EIPS/eip-197
     const GENERATOR: Self = G1Affine {