an abstract reduction tool for re-association

Author: Alex-Jordan

lib/Parser/BOP.pm

@@ -302,6 +302,32 @@ sub swapOps {
 	return $self;
 }
 
+#
+#  Change an association "(a bop b) bop c" to "a bop (b bop c)" or vice versa
+#  argument $dir should be 'left' or 'right'
+#  'left'  for "a bop (b bop c)" to become "(a bop b) bop c"
+#  'right' for "(a bop b) bop c" to become "a bop (b bop c)"
+#  Assumes the calling entity verified it is appropriate to associate
+#
+sub associateOps {
+	my $self = shift;
+	my $dir  = shift;
+	if ($dir eq 'left') {
+		return $self->Item('BOP')->new(
+			$self->{equation}, $self->{bop},
+			$self->Item('BOP')->new($self->{equation}, $self->{bop}, $self->{lop}, $self->{rop}{lop})->reduce,
+			$self->{rop}{rop}
+		)->reduce;
+	} else {
+		return $self->Item('BOP')->new(
+			$self->{equation},
+			$self->{lop}{bop},
+			$self->{lop}{lop},
+			$self->Item('BOP')->new($self->{equation}, $self->{bop}, $self->{lop}{rop}, $self->{rop})
+		)->reduce;
+	}
+}
+
 #
 #  Get the variables from the two operands
 #

lib/Parser/BOP/multiply.pm

@@ -68,21 +68,11 @@ sub _reduce {
 	$self->swapOps
 		if (($self->{rop}->class eq 'Number' && $self->{lop}->class ne 'Number' && $reduce->{'x*n'})
 			|| ($self->{lop}->class eq 'Function' && $self->{rop}->class ne 'Function' && $reduce->{'fn*x'}));
-
-	if ($reduce->{'m*(n*x)'}
-		&& defined $self->{lop}
-		&& defined $self->{rop}{lop}
-		&& defined $self->{rop}{bop}
-		&& $self->{lop}->class eq 'Number'
-		&& $self->{rop}{lop}->class eq 'Number'
-		&& $self->{rop}{bop} eq '*')
-	{
-		my $m = $self->{lop};
-		$self->{lop} = $self->{rop}->copy;
-		$self->{lop}->swapOps;
-		$self->{lop}{lop} = $m;
-		$self->{rop} = $self->{rop}{rop};
-	}
+	$self = $self->associateOps('left')
+		if ($reduce->{'m*(n*x)'}
+			&& $self->{lop}->class eq 'Number'
+			&& $self->{rop}->isa('Parser::BOP::multiply')
+			&& $self->{rop}{lop}->class eq 'Number');
 	return $self;
 }