Unused modules in check_modules?

[dlglin]

Looking through check_modules.pl there are a number of modules that are not referenced anywhere in the WW or PG code:

• Array::Utils
• Email::Sender::Simple
• HTML::Tagset
• HTML::Template
• IO::Socket::SSL
• Net::LDAPS
• Net::SMTP
• Net::SSLeay
• PadWalker
• Path::Class
• Template

Are these no longer required? Is it possible that other perl packages depend on some of these? If so, do we need them in check_modules.pl?

If these truly aren't being used then I can put in a PR to remove them from check_modules.pl.

[drgrice1]

I think those need to be deleted. If a package depends on them, then there is no need for them to be checked as long as the package that depends on them is checked.

[pstaabp]

Net::LDAP is used, but not in check_modules. Looks like the LDAPS version is for secure, but Net::LDAP seems to handle security as well. Maybe replace Net::LDAPS with Net::LDAP

[pstaabp]

Also, if we're going to remove these, check the packages in Docker as well. I just did a search for padwalker which is in the Dockerfiles.

[drgrice1]

Docker doesn't need to install libpadwalker-perl. It also doesn't need to install libarray-utils-perl, libhtml-template-perl, libtemplate-perl, and libpath-class-perl. There may be others too.

[pstaabp]

Docker doesn't need to install libpadwalker-perl. It also doesn't need to install libarray-utils-perl, libhtml-template-perl, libtemplate-perl, and libpath-class-perl. There may be others too.

@dlglin if you put in a PR for this, let's clean up all of the Docker stuff as well.

[dlglin]

Does Docker take care of dependencies, or do they need to be explicitly listed?

[dlglin]

node is in check_modules, but npm isn't. Should npm be there?

[drgrice1]

Which dependencies are you referring to for Docker? If you mean the Ubuntu packages, then that isn't a Docker controlled thing. That would be apt. apt will pull in any necessary dependencies. They do not need to be explicitly listed.

Yes, npm should be in check_modules. It is possible to have node installed, but not have npm installed. So really both should be listed.

[pstaabp]

@dlglin Are you still putting in a PR to do this. Looks like in #2014 the docker modules are updated.

[somiaj]

This should have been cleaned up in #2741, extra modules have been removed.