Skip to content

Commit 2247a6d

Browse files
[GR-61979] Espresso: harmonize style regarding empty line after license header.
PullRequest: graal/19995
2 parents 3d54364 + 682a1dc commit 2247a6d

File tree

325 files changed

+4
-521
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

325 files changed

+4
-521
lines changed

espresso/ci/ci.jsonnet

-10
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,6 @@
3737
common.jdk21_weekly_bench_linux + common.espresso_interpreter_benchmark('jvm-ce-llvm', 'awfy:*') + {name: 'weekly-bench-espresso-jvm-ce-awfy_interpreter-jdk21-linux-amd64'},
3838
common.jdk21_weekly_bench_linux + common.espresso_interpreter_benchmark('native-ce-llvm', 'awfy:*') + {name: 'weekly-bench-espresso-native-ce-awfy_interpreter-jdk21-linux-amd64'},
3939

40-
// Scala DaCapo warmup benchmarks
41-
common.jdk21_weekly_bench_linux + common.scala_dacapo_warmup_benchmark('jvm-ce-llvm' , guest_jvm_config='single-tier' , extra_args=['--vm.XX:ReservedCodeCacheSize=1g']) + {name: 'weekly-bench-espresso-jvm-ce-scala_dacapo_warmup-single_tier-jdk21-linux-amd64'},
42-
common.jdk21_weekly_bench_linux + common.scala_dacapo_warmup_benchmark('native-ce-llvm', guest_jvm_config='single-tier') + {name: 'weekly-bench-espresso-native-ce-scala_dacapo_warmup-single_tier-jdk21-linux-amd64'},
43-
common.jdk21_weekly_bench_linux + common.scala_dacapo_warmup_benchmark('jvm-ce-llvm' , guest_jvm_config='multi-tier' , extra_args=['--vm.XX:ReservedCodeCacheSize=1g']) + {name: 'weekly-bench-espresso-jvm-ce-scala_dacapo_warmup-multi_tier-jdk21-linux-amd64'},
44-
common.jdk21_weekly_bench_linux + common.scala_dacapo_warmup_benchmark('native-ce-llvm', guest_jvm_config='multi-tier') + {name: 'weekly-bench-espresso-native-ce-scala_dacapo_warmup-multi_tier-jdk21-linux-amd64'},
45-
common.jdk21_weekly_bench_linux + common.graal_benchmark('jvm-ce-llvm', common.scala_dacapo_jvm_warmup) + {name: 'weekly-bench-espresso-jvm-ce-scala_dacapo_warmup-reference-jdk21-linux-amd64'},
46-
47-
common.jdk21_weekly_bench_linux + common.scala_dacapo_warmup_benchmark('jvm-ce-llvm' , guest_jvm_config='3-compiler-threads', extra_args=['--vm.XX:ReservedCodeCacheSize=1g']) + {name: 'weekly-bench-espresso-jvm-ce-scala_dacapo_warmup-3threads-jdk21-linux-amd64'},
48-
common.jdk21_weekly_bench_linux + common.scala_dacapo_warmup_benchmark('native-ce-llvm', guest_jvm_config='3-compiler-threads') + {name: 'weekly-bench-espresso-native-ce-scala_dacapo_warmup-3threads-jdk21-linux-amd64'},
49-
5040
// Scala DaCapo benchmarks
5141
common.jdk21_on_demand_bench_linux + common.scala_dacapo_benchmark('jvm-ce-llvm' , guest_jvm_config='single-tier' , extra_args=['--vm.XX:ReservedCodeCacheSize=1g']) + {name: 'ondemand-bench-espresso-jvm-ce-scala_dacapo-single_tier-jdk21-linux-amd64'},
5242
common.jdk21_on_demand_bench_linux + common.scala_dacapo_benchmark('native-ce-llvm' , guest_jvm_config='single-tier') + {name: 'ondemand-bench-espresso-native-ce-scala_dacapo-single_tier-jdk21-linux-amd64'},

espresso/ci/ci_common/common.jsonnet

-13
Original file line numberDiff line numberDiff line change
@@ -221,15 +221,6 @@ local benchmark_suites = ['dacapo', 'renaissance', 'scala-dacapo'];
221221
espresso_interpreter_benchmark(env, suite, host_jvm=null):
222222
self.espresso_benchmark(env, suite, host_jvm=host_jvm, guest_jvm_config='interpreter', extra_args=['--', '--iterations', '10']),
223223

224-
scala_dacapo_warmup_benchmark(env, guest_jvm_config='default', extra_args=[]):
225-
self.espresso_benchmark(
226-
env,
227-
self.scala_dacapo_jvm_warmup,
228-
guest_jvm_config=guest_jvm_config,
229-
extra_args=extra_args,
230-
timelimit='5:00:00'
231-
),
232-
233224
scala_dacapo_benchmark(env, guest_jvm_config, extra_args=[]):
234225
self.espresso_benchmark(
235226
env,
@@ -266,10 +257,6 @@ local benchmark_suites = ['dacapo', 'renaissance', 'scala-dacapo'];
266257
}
267258
+ self.bench_upload,
268259

269-
# Scala DaCapo benchmarks that run in both JVM and native modes,
270-
# Excluding factorie (too slow). kiama and scalariform have transient issues with compilation enabled.
271-
scala_dacapo_jvm_warmup: 'scala-dacapo-warmup:*[scalap,scalac,scaladoc,scalaxb]',
272-
273260
dacapo_stable(env): 'dacapo:*[fop,lusearch,luindex,sunflow,xalan]',
274261

275262
# exclude scalatest, which goes into deopt loop and becomes slower on every subsequent operation

espresso/mx.espresso/mx_espresso_benchmarks.py

-72
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,11 @@
2020
# or visit www.oracle.com if you need additional information or have any
2121
# questions.
2222
#
23-
24-
import argparse
25-
2623
import mx
2724
import mx_benchmark
2825
import mx_espresso
2926

3027
from mx_benchmark import GuestVm, JavaVm
31-
from mx_sdk_benchmark import ScalaDaCapoBenchmarkSuite
3228
from mx_sdk_benchmark import _daCapoScalaConfig
3329

3430

@@ -187,71 +183,3 @@ def warmupIterations(startup=None, earlyWarmup=None, lateWarmup=None):
187183
"specs" : warmupIterations(1, 1 + _daCapoScalaConfig["specs"] // 3, _daCapoScalaConfig["specs"]),
188184
"tmt" : warmupIterations(1, 1 + _daCapoScalaConfig["tmt"] // 3, _daCapoScalaConfig["tmt"]),
189185
}
190-
191-
class ScalaDaCapoWarmupBenchmarkSuite(ScalaDaCapoBenchmarkSuite): #pylint: disable=too-many-ancestors
192-
"""Scala DaCapo (warmup) benchmark suite implementation."""
193-
194-
def daCapoPath(self):
195-
return mx.distribution("DACAPO_SCALA_WARMUP").path
196-
197-
def name(self):
198-
return "scala-dacapo-warmup"
199-
200-
def warmupResults(self, results, warmupIterations, metricName="cumulative-warmup"):
201-
"""
202-
Postprocess results to add new entries for specific iterations.
203-
"""
204-
benchmarkNames = {r["benchmark"] for r in results}
205-
for benchmark in benchmarkNames:
206-
if benchmark in warmupIterations:
207-
entries = [result for result in results if result["metric.name"] == metricName and result["benchmark"] == benchmark]
208-
if entries:
209-
for entry in entries:
210-
for key, iteration in warmupIterations[benchmark].items():
211-
if entry["metric.iteration"] == iteration - 1: # scala_dacapo_warmup_iterations is 1-based, JSON output is 0-based
212-
newEntry = entry.copy()
213-
newEntry["metric.name"] = key
214-
results.append(newEntry)
215-
216-
def rules(self, out, benchmarks, bmSuiteArgs):
217-
super_rules = super(ScalaDaCapoWarmupBenchmarkSuite, self).rules(out, benchmarks, bmSuiteArgs)
218-
return super_rules + [
219-
mx_benchmark.StdOutRule(
220-
r"===== DaCapo (?P<version>\S+) (?P<benchmark>[a-zA-Z0-9_]+) walltime [0-9]+ : (?P<time>[0-9]+) msec =====", # pylint: disable=line-too-long
221-
{
222-
"benchmark": ("<benchmark>", str),
223-
"bench-suite": self.benchSuiteName(),
224-
"vm": "jvmci",
225-
"config.name": "default",
226-
"config.vm-flags": self.shorten_vm_flags(self.vmArgs(bmSuiteArgs)),
227-
"metric.name": "walltime",
228-
"metric.value": ("<time>", int),
229-
"metric.unit": "ms",
230-
"metric.type": "numeric",
231-
"metric.score-function": "id",
232-
"metric.better": "lower",
233-
"metric.iteration": ("$iteration", int)
234-
}
235-
)
236-
]
237-
238-
def postprocessRunArgs(self, benchname, runArgs):
239-
parser = argparse.ArgumentParser(add_help=False)
240-
parser.add_argument("-n", default=None)
241-
args, remaining = parser.parse_known_args(runArgs)
242-
result = ['-c', 'WallTimeCallback'] + remaining
243-
if args.n:
244-
if args.n.isdigit():
245-
result = ["-n", args.n] + result
246-
else:
247-
iterations = scala_dacapo_warmup_iterations[benchname]["late-warmup"]
248-
result = ["-n", str(iterations)] + result
249-
return result
250-
251-
def run(self, benchmarks, bmSuiteArgs):
252-
results = super(ScalaDaCapoWarmupBenchmarkSuite, self).run(benchmarks, bmSuiteArgs)
253-
self.warmupResults(results, scala_dacapo_warmup_iterations, 'walltime')
254-
# walltime entries are not accepted by the bench server
255-
return [e for e in results if e["metric.name"] != "walltime"]
256-
257-
mx_benchmark.add_bm_suite(ScalaDaCapoWarmupBenchmarkSuite())

espresso/mx.espresso/suite.py

-39
Original file line numberDiff line numberDiff line change
@@ -363,17 +363,6 @@
363363
},
364364
},
365365

366-
"com.oracle.truffle.espresso.dacapo": {
367-
"subDir": "src",
368-
"sourceDirs": ["src"],
369-
"dependencies": [
370-
"sdk:DACAPO_SCALA",
371-
],
372-
"javaCompliance": "8+",
373-
"checkstyle": "com.oracle.truffle.espresso",
374-
"testProject" : True,
375-
},
376-
377366
"com.oracle.truffle.espresso.shadowed.asm" : {
378367
# Shadowed ASM library (org.ow2.asm:asm)
379368
"subDir" : "src",
@@ -706,33 +695,5 @@
706695
"description": "JVMCI implementation for Espresso",
707696
"maven": False,
708697
},
709-
710-
"DACAPO_SCALA_WARMUP": {
711-
"subDir": "src",
712-
"dependencies": [
713-
"com.oracle.truffle.espresso.dacapo",
714-
"sdk:DACAPO_SCALA",
715-
],
716-
"testDistribution": True,
717-
"manifestEntries" : {
718-
"Manifest-Version": "1.0",
719-
"Build-Timestamp": "2012-02-16T11:12:52",
720-
"Implementation-Title": "Scala Benchmark Suite",
721-
"Implementation-Version": "0.1.0-SNAPSHOT",
722-
"Built-By": "sewe",
723-
"Specification-Vendor": "Technische Universitat Darmstadt",
724-
"Created-By": "Apache Maven 3.0.4",
725-
"Implementation-Vendor": "Technische Universitat Darmstadt",
726-
"Build-Number": "02fbc0d55f60",
727-
"Implementation-Vendor-Id": "org.scalabench.benchmarks",
728-
"Build-Jdk": "1.6.0_26",
729-
"Specification-Title": "Scala Benchmark Suite",
730-
"Specification-Version": "0.1.0-SNAPSHOT",
731-
"Main-Class": "Harness",
732-
"Archiver-Version": "Plexus Archiver",
733-
},
734-
"description": "Scala DaCapo with WallTime callback",
735-
"maven": False,
736-
},
737698
}
738699
}

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/JavaVersion.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile;
2524

2625
/**

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/attributes/EnclosingMethodAttribute.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.attributes;
2524

2625
import com.oracle.truffle.espresso.classfile.descriptors.Name;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/attributes/InnerClassesAttribute.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.attributes;
2524

2625
import com.oracle.truffle.espresso.classfile.descriptors.Name;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/attributes/NestHostAttribute.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.attributes;
2524

2625
import com.oracle.truffle.espresso.classfile.descriptors.Name;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/attributes/NestMembersAttribute.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.attributes;
2524

2625
import com.oracle.truffle.api.CompilerDirectives;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/attributes/PermittedSubclassesAttribute.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.attributes;
2524

2625
import com.oracle.truffle.api.CompilerDirectives;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/attributes/RecordAttribute.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.attributes;
2524

2625
import com.oracle.truffle.api.CompilerDirectives;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/attributes/StackMapTableAttribute.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.attributes;
2524

2625
import com.oracle.truffle.espresso.classfile.descriptors.Name;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/bytecode/Bytecodes.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.bytecode;
2524

2625
import static com.oracle.truffle.espresso.classfile.bytecode.Bytecodes.Flags.ASSOCIATIVE;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/bytecode/VolatileArrayAccess.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.bytecode;
2524

2625
import java.lang.invoke.MethodHandles;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/DebugCloseable.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.perf;
2524

2625
/**

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/DebugCounter.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.perf;
2524

2625
import java.io.PrintStream;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/DebugTimer.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.perf;
2524

2625
import java.util.ArrayList;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/TimerCollection.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.perf;
2524

2625
import com.oracle.truffle.api.TruffleLogger;

espresso/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/TimerCollectionImpl.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.classfile.perf;
2524

2625
import java.util.HashSet;

espresso/src/com.oracle.truffle.espresso.dacapo/src/WallTimeCallback.java

-67
This file was deleted.

espresso/src/com.oracle.truffle.espresso.libjavavm/src/com/oracle/truffle/espresso/libjavavm/arghelper/ArgumentsHandler.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.libjavavm.arghelper;
2524

2625
import static com.oracle.truffle.espresso.libjavavm.Arguments.abort;

espresso/src/com.oracle.truffle.espresso.libjavavm/src/com/oracle/truffle/espresso/libjavavm/arghelper/Native.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.libjavavm.arghelper;
2524

2625
import static com.oracle.truffle.espresso.libjavavm.Arguments.abort;

espresso/src/com.oracle.truffle.espresso.libjavavm/src/com/oracle/truffle/espresso/libjavavm/arghelper/PolyglotArgs.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* or visit www.oracle.com if you need additional information or have any
2121
* questions.
2222
*/
23-
2423
package com.oracle.truffle.espresso.libjavavm.arghelper;
2524

2625
import static com.oracle.truffle.espresso.libjavavm.Arguments.abort;

0 commit comments

Comments
 (0)