Skip to content

lack of ui parameter propagation in Repository and related classes #3862

Open
@vladak

Description

@vladak

The ui parameter used in getLastHistoryEntry() is largely ignored. Firstly, in the repository.getLastHistoryEntry() fallback path - none of the Repository#getHistory() methods actually have the ui parameter. Also, the historyCache.get() can fall back to repository.getHistory() as is the case with FileHistoryCache#get(). Even the classes that override Repository#getLastHistoryEntry(File file, boolean ui) ignore the ui parameter - because the getHistory() method they are usually based on lacks it.

Originally posted by @vladak in #3861 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions