Skip to content

Commit 274281a

Browse files
committed
Fix Vinenthz's parse validation
vincenthz/libjson#24
1 parent a87aa00 commit 274281a

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

sample/conformance.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5685,7 +5685,7 @@ <h2>Source CSV</h2>
56855685
1. Parse Validation,Vinenthz/libjson (C),pass01,true
56865686
1. Parse Validation,Vinenthz/libjson (C),pass02,true
56875687
1. Parse Validation,Vinenthz/libjson (C),pass03,true
5688-
1. Parse Validation,Vinenthz/libjson (C),fail02,false
5688+
1. Parse Validation,Vinenthz/libjson (C),fail02,true
56895689
1. Parse Validation,Vinenthz/libjson (C),fail03,true
56905690
1. Parse Validation,Vinenthz/libjson (C),fail04,true
56915691
1. Parse Validation,Vinenthz/libjson (C),fail05,true
@@ -5714,7 +5714,7 @@ <h2>Source CSV</h2>
57145714
1. Parse Validation,Vinenthz/libjson (C),fail29,true
57155715
1. Parse Validation,Vinenthz/libjson (C),fail30,true
57165716
1. Parse Validation,Vinenthz/libjson (C),fail31,true
5717-
1. Parse Validation,Vinenthz/libjson (C),fail32,false
5717+
1. Parse Validation,Vinenthz/libjson (C),fail32,true
57185718
1. Parse Validation,Vinenthz/libjson (C),fail33,true
57195719
2. Parse Double,Vinenthz/libjson (C),double01,true
57205720
2. Parse Double,Vinenthz/libjson (C),double02,true

sample/conformance_Vinenthz_libjson (C).md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,8 @@
22

33
## 1. Parse Validation
44

5-
* `../data/jsonchecker/fail02.json` is invalid but was mistakenly deemed valid.
6-
~~~js
7-
["Unclosed array"
8-
~~~
9-
10-
* `../data/jsonchecker/fail32.json` is invalid but was mistakenly deemed valid.
11-
~~~js
12-
{"Comma instead if closing brace": true,
13-
~~~
14-
155

16-
Summary: 32 of 34 are correct.
6+
Summary: 34 of 34 are correct.
177

188
## 2. Parse Double
199

src/tests/vincenthzlibjsontest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ class VinenthzTest : public TestBase {
398398
json_parser_dom_init(&dom, tree_create_structure, tree_create_data, tree_append);
399399
json_parser_init(&parser, &config, json_parser_dom_callback, &dom);
400400
uint32_t processed;
401-
if (!json_parser_string(&parser, json, (uint32_t)length, &processed))
401+
if (!json_parser_string(&parser, json, (uint32_t)length, &processed) && json_parser_is_done(&parser))
402402
pr->root = (json_val_t*)dom.root_structure;
403403
else {
404404
delete pr;

0 commit comments

Comments
 (0)