Skip to content

The attribute string representation is tailing with a newline now #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zjp-CN opened this issue May 18, 2025 · 0 comments
Closed

The attribute string representation is tailing with a newline now #69

zjp-CN opened this issue May 18, 2025 · 0 comments

Comments

@zjp-CN
Copy link
Member

zjp-CN commented May 18, 2025

rust-lang/rust#140689 especially rust-lang/rust@e1a177b adds a newline in attributes.

The diff of the affect: d201112#diff-715dddd36ccd9d7762320dee3daa442155492b662edfdeef6d9defcd05ee469eL5-R5

rustdoc-json decides to remove the trailing newline: rust-lang/rust#140762

It doesn't make sense to keep the newline in this tool, either. So we should remove it from each attribute.
@zjp-CN zjp-CN changed the title The attibute string representation is tailing with a newline now The attribute string representation is tailing with a newline now May 18, 2025
@zjp-CN zjp-CN closed this as completed in c8f54f5 May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zjp-CN