Skip to content

Commit e40b02e

Browse files
tordanswillemarcel
authored andcommitted
target=_blank add noopener fix eslint error
>Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener > eslint(react/jsx-no-target-blank)
1 parent 5560093 commit e40b02e

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

lib/dropdown.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ class DropdownContent extends React.PureComponent {
6464
)}
6565
{i.href ? (
6666
<a
67-
target={'_blank'}
68-
rel="noreferrer"
67+
target="_blank"
68+
rel="noopener noreferrer"
6969
href={i.href}
7070
onClick={this.props.toggleDropdown}
7171
className={`${this.isActive(i) ? 'is-active' : ''}`}

lib/sidebar.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ export class Sidebar extends React.PureComponent {
192192
<li>
193193
<a
194194
target="_blank"
195-
rel="noreferrer"
195+
rel="noopener noreferrer"
196196
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-c-link-osm"
197197
href={'https://openstreetmap.org/changeset/' + changesetId}
198198
>
@@ -202,7 +202,7 @@ export class Sidebar extends React.PureComponent {
202202
<li>
203203
<a
204204
target="_blank"
205-
rel="noreferrer"
205+
rel="noopener noreferrer"
206206
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-c-link-osmcha"
207207
href={`${config.osmchaBase}changesets/${changesetId}/`}
208208
>
@@ -212,7 +212,7 @@ export class Sidebar extends React.PureComponent {
212212
<li>
213213
<a
214214
target="_blank"
215-
rel="noreferrer"
215+
rel="noopener noreferrer"
216216
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-c-link-achavi"
217217
href={
218218
'https://overpass-api.de/achavi/?changeset=' + changesetId
@@ -224,7 +224,7 @@ export class Sidebar extends React.PureComponent {
224224
<li>
225225
<a
226226
target="_blank"
227-
rel="noreferrer"
227+
rel="noopener noreferrer"
228228
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-c-link-osmhv"
229229
href={
230230
'http://osmhv.openstreetmap.de/changeset.jsp?id=' +
@@ -237,7 +237,7 @@ export class Sidebar extends React.PureComponent {
237237
<li>
238238
<a
239239
target="_blank"
240-
rel="noreferrer"
240+
rel="noopener noreferrer"
241241
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-c-link-josm"
242242
href={
243243
'http://127.0.0.1:8111/import?url=http://www.openstreetmap.org/api/0.6/changeset/' +
@@ -251,7 +251,7 @@ export class Sidebar extends React.PureComponent {
251251
<li>
252252
<a
253253
target="_blank"
254-
rel="noreferrer"
254+
rel="noopener noreferrer"
255255
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-c-link-id"
256256
href={
257257
'http://preview.ideditor.com/release#map=15/' +
@@ -280,7 +280,7 @@ export class Sidebar extends React.PureComponent {
280280
<li>
281281
<a
282282
target="_blank"
283-
rel="noreferrer"
283+
rel="noopener noreferrer"
284284
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-u-link-osm"
285285
href={'https://openstreetmap.org/user/' + userName}
286286
>
@@ -290,7 +290,7 @@ export class Sidebar extends React.PureComponent {
290290
<li>
291291
<a
292292
target="_blank"
293-
rel="noreferrer"
293+
rel="noopener noreferrer"
294294
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-u-link-hdyc"
295295
href={'http://hdyc.neis-one.org/?' + userName}
296296
>
@@ -300,7 +300,7 @@ export class Sidebar extends React.PureComponent {
300300
<li>
301301
<a
302302
target="_blank"
303-
rel="noreferrer"
303+
rel="noopener noreferrer"
304304
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-u-link-disc"
305305
href={
306306
'http://resultmaps.neis-one.org/osm-discussion-comments?uid=' +
@@ -313,7 +313,7 @@ export class Sidebar extends React.PureComponent {
313313
<li>
314314
<a
315315
target="_blank"
316-
rel="noreferrer"
316+
rel="noopener noreferrer"
317317
className="cmap-hlist-item cmap-noselect cmap-pointer cmap-u-link-comm"
318318
href={
319319
'http://resultmaps.neis-one.org/osm-discussion-comments?uid=115894' +

0 commit comments

Comments
 (0)