fix(conan)!: Use a Conan profile named ort-default instead of the default

This new profile is created with `-detect` therefore it will contains the
compilation flags. This is cleaner as it allows to remove the passing of
the compilation flags from the package manager. It also fix the usage of
Conan on non-Linux plaforms.

Signed-off-by: Nicolas Nobelis <[email protected]>

Author: nnobelis

plugins/package-managers/conan/src/main/kotlin/Conan.kt

@@ -202,6 +202,8 @@ class Conan(
                 config.lockfileName?.let { hasLockfile(workingDir.resolve(it).path) } == true
             }
 
+            handler.createConanProfileIfNeeded()
+
             val handlerResults = handler.process(definitionFile, config.lockfileName)
 
             val result = with(handlerResults) {

plugins/package-managers/conan/src/main/kotlin/ConanV1Handler.kt

@@ -44,6 +44,12 @@ import org.ossreviewtoolkit.utils.ort.createOrtTempDir
 internal class ConanV1Handler(private val conan: Conan) : ConanVersionHandler {
     override fun getConanHome(): File = Os.userHomeDirectory.resolve(".conan")
 
+    override fun createConanProfileIfNeeded() {
+        if (!getConanHome().resolve("profiles/ort-default").isFile) {
+            conan.command.run("profile", "new", "ort-default", "--detect").requireSuccess()
+        }
+    }
+
     override fun getConanStoragePath(): File = getConanHome().resolve("data")
 
     override fun process(definitionFile: File, lockfileName: String?): HandlerResults {
@@ -64,7 +70,9 @@ internal class ConanV1Handler(private val conan: Conan) : ConanVersionHandler {
                 definitionFile.name,
                 "--json",
                 jsonFile.absolutePath,
-                *DUMMY_COMPILER_SETTINGS
+                *DUMMY_COMPILER_SETTINGS,
+                "--profile",
+                "ort-default"
             ).requireSuccess()
         }
 

plugins/package-managers/conan/src/main/kotlin/ConanV2Handler.kt

@@ -47,16 +47,17 @@ import org.ossreviewtoolkit.utils.ort.createOrtTempDir
 internal class ConanV2Handler(private val conan: Conan) : ConanVersionHandler {
     override fun getConanHome(): File = Os.userHomeDirectory.resolve(".conan2")
 
+    override fun createConanProfileIfNeeded() {
+        if (!getConanHome().resolve("profiles/ort-default").isFile) {
+            conan.command.run("profile", "detect", "--name", "ort-default").requireSuccess()
+        }
+    }
+
     override fun getConanStoragePath(): File = getConanHome().resolve("p")
 
     override fun process(definitionFile: File, lockfileName: String?): HandlerResults {
         val workingDir = definitionFile.parentFile
 
-        // Create a default build profile.
-        if (!getConanHome().resolve("profiles/default").isFile) {
-            conan.command.run(workingDir, "profile", "detect")
-        }
-
         val jsonFile = createOrtTempDir().resolve("info.json")
         if (lockfileName != null) {
             conan.verifyLockfileBelongsToProject(workingDir, lockfileName)
@@ -83,7 +84,9 @@ internal class ConanV2Handler(private val conan: Conan) : ConanVersionHandler {
                 "--out-file",
                 jsonFile.absolutePath,
                 *DUMMY_COMPILER_SETTINGS,
-                definitionFile.name
+                definitionFile.name,
+                "--profile",
+                "ort-default"
             ).requireSuccess()
         }
 

plugins/package-managers/conan/src/main/kotlin/ConanVersionHandler.kt

@@ -35,6 +35,11 @@ internal interface ConanVersionHandler {
      */
     fun getConanHome(): File
 
+    /**
+     * Create a default ORT Conan profile if it does not exist yet. This profile will contain the complication flags.
+     */
+    fun createConanProfileIfNeeded()
+
     /**
      * Get the Conan storage path, i.e. the location where Conan caches downloaded packages.
      */