You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: sled-agent/src/instance_manager.rs
+10-2Lines changed: 10 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -387,7 +387,11 @@ impl InstanceManager {
387
387
{
388
388
Ok(HandleInstancePutResultResult::Ok) => {}
389
389
Ok(HandleInstancePutResultResult::TimedOut) => {
390
-
todo!("nexus doesn't want us any more, terminate instance")
390
+
error!(log,"Nexus gave up waiting for us to finish creating the propolis zone and abandoned the instance. Rudely terminating it from our side.";"instance_id" => %instance_id);
391
+
ifletErr(err) = instance.terminate().await
392
+
{
393
+
error!(log,"Couldn't terminate instance whose creation was timed-out by Nexus";"instance_id" => %instance_id,"err" => %err);
394
+
}
391
395
}
392
396
Err(err) => {
393
397
error!(log,"Failed to inform Nexus of instance_put success";
@@ -409,7 +413,11 @@ impl InstanceManager {
409
413
{
410
414
Ok(HandleInstancePutResultResult::Ok) => {}
411
415
Ok(HandleInstancePutResultResult::TimedOut) => {
412
-
todo!("well, i guess this is less awkward but clean up if we have to")
416
+
error!(log,"Nexus gave up waiting for us to finish creating the propolis zone and abandoned the instance, but the instance also explicitly failed on our side. Rudely terminating what remains of it.";"instance_id" => %instance_id);
417
+
ifletErr(err) = instance.terminate().await
418
+
{
419
+
error!(log,"Couldn't terminate faulted instance (whose creation was also timed-out by Nexus)";"instance_id" => %instance_id,"err" => %err);
420
+
}
413
421
}
414
422
Err(err) => {
415
423
error!(log,"Failed to inform Nexus of instance_put failure";
0 commit comments