Skip to content

what to do with zpool and physical_disk database tables after expungement #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leftwo opened this issue Apr 18, 2024 · 1 comment
Closed

Comments

@leftwo
Copy link
Contributor

leftwo commented Apr 18, 2024

There is a comment in issue #4787 around what happens to database tables in
a sled that has been removed. This section specifically:

## Database state
...

Besides those direct consumers, physical disks are referenced by the `zpool` 
table.  `zpool` is referenced by `dataset.pool_id` and some inventory tables.  
Again I think we can ignore inventory tables here.  `dataset` is referenced by 
`region.dataset_id` and `region_snapshot.dataset_id`.  I'm assuming that 
`physical_disk`, `zpool`, `dataset`, and `region` are well understood and covered 
by the open tickets around #4719 and Crucible region replacement.

Originally posted by @davepacheco in #4787 (comment)

The current plan for Crucible region replacement does not address what to do with
the zpool and physical_disk tables.

It may not be a problem to just leave them as they are, but I did want to call out that
at the moment, no special action is taken for these tables during the Crucible region
replacement work.

@davepacheco
Copy link
Collaborator

We discussed this briefly in today's update call and concluded that:

  • eventually, we may want to clean up zpool and physical_disk records, as we want to clean up tons of other kinds of records (e.g., old blueprints, completed sagas, deleted silos/projects/instances/VPCs/etc.); and
  • the presence of these records in the meantime is not a problem. e.g., we won't accidentally provision to the zpool because we're already filtering for disks or sleds that are in-service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants