Skip to content

Commit 00ab656

Browse files
authored
gh-529 Fixing Dataframe.insert (#543)
* Update test_frame.py * Update frame.pyi * Update test_frame.py * Changed assert_type * Update test_frame.py * Update test_frame.py
1 parent 537e67f commit 00ab656

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

pandas-stubs/core/frame.pyi

+1-1
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@ class DataFrame(NDFrame, OpsMixin):
542542
self,
543543
loc: int,
544544
column,
545-
value: int | ListLike,
545+
value: Scalar | ListLikeU | None,
546546
allow_duplicates: _bool = ...,
547547
) -> None: ...
548548
def assign(self, **kwargs) -> DataFrame: ...

tests/test_frame.py

+9
Original file line numberDiff line numberDiff line change
@@ -2410,3 +2410,12 @@ def test_in_columns() -> None:
24102410
check(assert_type(df.loc[:, cols], pd.DataFrame), pd.DataFrame)
24112411
check(assert_type(df[cols], pd.DataFrame), pd.DataFrame)
24122412
check(assert_type(df.groupby(by=cols).sum(), pd.DataFrame), pd.DataFrame)
2413+
2414+
2415+
def test_insert_newvalues() -> None:
2416+
df = pd.DataFrame({"a": [1, 2]})
2417+
ab = pd.DataFrame({"col1": [1, 2], "col2": [3, 4]})
2418+
ef = pd.DataFrame({"z": [4, 5, 6]})
2419+
assert assert_type(df.insert(loc=0, column="b", value=None), None) is None
2420+
assert assert_type(ab.insert(loc=0, column="newcol", value=[99, 99]), None) is None
2421+
assert assert_type(ef.insert(loc=0, column="g", value=4), None) is None

0 commit comments

Comments
 (0)