Fix CI clippy failures and CI script

Adding a Rustup update at the beginning of the CI script to ensure that
all of the checks, particularly with clippy, are done using the latest
version of the compiler toolchain.

Two issues flagged by clippy are also fixed.

Signed-off-by: Ionut Mihalcea <[email protected]>

Author: ionut-arm

ci.sh

@@ -126,6 +126,9 @@ setup_mappings() {
     reload_service
 }
 
+# Use the newest version of the Rust toolchain
+rustup update
+
 # Parse arguments
 NO_CARGO_CLEAN=
 NO_STRESS_TEST=
@@ -288,7 +291,6 @@ if [ "$PROVIDER_NAME" = "cargo-check" ]; then
     # - openSUSE Tumbleweed
     # - openSUSE Leap 15.3
     # The oldest is currently in openSUSE Leap 15.3 and is 1.53.0.
-    rustup update
 
     rustup toolchain install 1.53.0
     # The "jwt-svid-authenticator" can not be compiled on 1.53.0

src/providers/mbed_crypto/mod.rs

@@ -149,13 +149,10 @@ impl Provider {
                 }
             };
             for key_identity in to_remove.iter() {
-                if mbed_crypto_provider
+                mbed_crypto_provider
                     .key_info_store
                     .remove_key_info(key_identity)
-                    .is_err()
-                {
-                    return None;
-                }
+                    .ok()?;
             }
         }
         mbed_crypto_provider.id_counter.store(max_key_id, Relaxed);

src/providers/trusted_service/context/mod.rs

@@ -27,6 +27,7 @@ use ts_protobuf::GetOpcode;
     unused_qualifications
 )]
 pub mod ts_binding {
+    #![allow(deref_nullptr)]
     include!(concat!(env!("OUT_DIR"), "/ts_bindings.rs"));
 }