introduce activate-wasm-bindgen-features crate

Author: Andronik Ordian

.gitlab-ci.yml

@@ -303,13 +303,8 @@ check-web-wasm:
   script:
     # WASM support is in progress. As more and more crates support WASM, we
     # should add entries here. See https://github.com/paritytech/substrate/issues/2416
-    - time cargo build --target=wasm32-unknown-unknown -p sp-io
-    - time cargo build --target=wasm32-unknown-unknown -p sp-runtime
-    - time cargo build --target=wasm32-unknown-unknown -p sp-std
-    - time cargo build --target=wasm32-unknown-unknown -p sc-consensus-aura
-    - time cargo build --target=wasm32-unknown-unknown -p sc-consensus-babe
-    - time cargo build --target=wasm32-unknown-unknown -p sp-consensus
-    - time cargo build --target=wasm32-unknown-unknown -p sc-telemetry
+    # Note: we don't need to test crates imported in `bin/node/cli`
+    - time cargo build --manifest-path=client/consensus/aura/Cargo.toml --target=wasm32-unknown-unknown --features activate-wasm-bindgen-features
     # Note: the command below is a bit weird because several Cargo issues prevent us from compiling the node in a more straight-forward way.
     - time cargo +nightly build --manifest-path=bin/node/cli/Cargo.toml --no-default-features --features browser --target=wasm32-unknown-unknown -Z features=itarget
     # with-tracing must be explicitly activated, we run a test to ensure this works as expected in both cases

Cargo.lock

@@ -178,6 +178,7 @@ members = [
 	"test-utils/runtime/client",
 	"test-utils/runtime/transaction-pool",
 	"test-utils/test-crate",
+	"utils/activate-wasm-bindgen-features",
 	"utils/browser",
 	"utils/build-script-utils",
 	"utils/fork-tree",

Cargo.toml

@@ -37,6 +37,7 @@ sp-timestamp = { version = "2.0.0", path = "../../../primitives/timestamp" }
 sp-keystore = { version = "0.8.0", path = "../../../primitives/keystore" }
 sc-telemetry = { version = "2.0.0", path = "../../telemetry" }
 prometheus-endpoint = { package = "substrate-prometheus-endpoint", path = "../../../utils/prometheus", version = "0.8.0"}
+activate-wasm-bindgen-features = { version = "0.1.0", path = "../../../utils/activate-wasm-bindgen-features", optional = true }
 
 [dev-dependencies]
 sp-keyring = { version = "2.0.0", path = "../../../primitives/keyring" }

client/consensus/aura/Cargo.toml

@@ -0,0 +1,15 @@
+[package]
+name = "activate-wasm-bindgen-features"
+version = "0.1.0"
+authors = ["Parity Technologies <[email protected]>"]
+edition = "2018"
+license = "Apache-2.0"
+homepage = "https://substrate.dev"
+repository = "https://github.com/paritytech/substrate/"
+publish = false
+
+[dependencies]
+getrandom = { version = "0.2", features = ["js"] }
+rand = { version = "0.7", features = ["wasm-bindgen"] }
+futures-timer = { version = "3.0.1", features = ["wasm-bindgen"] }
+chrono = { version = "0.4", features = ["wasmbind"] }

utils/activate-wasm-bindgen-features/Cargo.toml

@@ -0,0 +1,18 @@
+// This file is part of Substrate.
+
+// Copyright (C) 2021 Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: Apache-2.0
+
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// 	http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+//! Activates `wasm-bindgen` features of various crates that we use.

utils/activate-wasm-bindgen-features/src/lib.rs

@@ -26,11 +26,6 @@ kvdb-web = "0.8.0"
 sp-database = { version = "2.0.0", path = "../../primitives/database" }
 sc-informant = { version = "0.8.0", path = "../../client/informant" }
 sc-service = { version = "0.8.0", path = "../../client/service", default-features = false }
-sc-network = { path = "../../client/network", version = "0.8.0"}
-sc-chain-spec = { path = "../../client/chain-spec", version = "2.0.0"}
-
-# Imported just for the `wasm-bindgen` feature
-getrandom = { version = "0.2", features = ["js"] }
-rand = { version = "0.7", features = ["wasm-bindgen"] }
-futures-timer = { version = "3.0.1", features = ["wasm-bindgen"]}
-chrono = { version = "0.4", features = ["wasmbind"] }
+sc-network = { path = "../../client/network", version = "0.8.0" }
+sc-chain-spec = { path = "../../client/chain-spec", version = "2.0.0" }
+activate-wasm-bindgen-features = { version = "0.1.0", path = "../activate-wasm-bindgen-features" }