Skip to content

Commit 284da09

Browse files
authored
fix: Invalid push notification tokens are not cleaned up from database for FCM API v2 (#9173)
1 parent 91dde99 commit 284da09

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

src/StatusHandler.js

+14-2
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,23 @@ export function pushStatusHandler(config, existingObjectId) {
237237
) {
238238
const token = result.device.deviceToken;
239239
const error = result.response.error;
240-
// GCM errors
240+
// GCM / FCM HTTP v1 API errors; see:
241+
// https://firebase.google.com/docs/reference/fcm/rest/v1/ErrorCode
241242
if (error === 'NotRegistered' || error === 'InvalidRegistration') {
242243
devicesToRemove.push(token);
243244
}
244-
// APNS errors
245+
// FCM API v2 errors; see:
246+
// https://firebase.google.com/docs/cloud-messaging/manage-tokens
247+
// https://github.com/firebase/functions-samples/blob/703c0359eacf07a551751d1319d34f912a2cd828/Node/fcm-notifications/functions/index.js#L89-L93C16
248+
if (
249+
error?.code === 'messaging/registration-token-not-registered' ||
250+
error?.code === 'messaging/invalid-registration-token' ||
251+
(error?.code === 'messaging/invalid-argument' && error?.message === 'The registration token is not a valid FCM registration token')
252+
) {
253+
devicesToRemove.push(token);
254+
}
255+
// APNS errors; see:
256+
// https://developer.apple.com/documentation/usernotifications/handling-notification-responses-from-apns
245257
if (error === 'Unregistered' || error === 'BadDeviceToken') {
246258
devicesToRemove.push(token);
247259
}

0 commit comments

Comments
 (0)